libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: branch-1-5 spurious quote.test failures


From: Ralf Wildenhues
Subject: FYI: branch-1-5 spurious quote.test failures
Date: Thu, 3 Feb 2005 11:04:05 +0100
User-agent: Mutt/1.5.6+20040907i

Already fixed in other branches.

 
        * tests/quote.test: Backport fix for spurious failures on Cygwin.

Index: tests/quote.test
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/quote.test,v
retrieving revision 1.6.2.1
diff -u -r1.6.2.1 quote.test
--- tests/quote.test    31 Jan 2005 17:26:22 -0000      1.6.2.1
+++ tests/quote.test    3 Feb 2005 10:01:24 -0000
@@ -95,7 +95,10 @@
   # We used to have the contents of $match in the case statement,
   # without an intermediate variable, but it would fail on at least
   # Solaris' and HP-UX's /bin/sh.  Ugh!
-  match="$preargs ${match_preflag}${flag}test "
+  # We must nost attempt to match $preargs in the output, because libtool
+  # may modify them.  For example, on Cygwin, ``libtool --mode=link gcc -o
+  # foo foo.o''  becomes ``gcc -o foo.exe foo.o''.
+  match="${match_preflag}${flag}test "
   case "$result" in
   *"$match"*)
     $echo "= passed: $result"
@@ -110,7 +113,7 @@
   for mchar in \\ \" \` \$; do
     $echo "= trying: \\$mchar quoting"
     result=`$libtool -n --mode=$mode $preargs 
${preflag}"${flag}${mchar}test${mchar}" $postargs` || status=1
-    match="$preargs ${match_preflag}${flag}\\${mchar}test\\${mchar} "
+    match="${match_preflag}${flag}\\${mchar}test\\${mchar} "
     case "$result" in
     *"$match"*)
       $echo "= passed: $result"
@@ -128,7 +131,7 @@
 
     $echo "= trying: \"$mchar\" quoting"
     result=`$libtool -n --mode=$mode $preargs 
${preflag}"${flag}${mchar}test${mchar}" $postargs` || status=1
-    match="$preargs ${match_preflag}\"${flag}${mchar}test${mchar}\" "
+    match="${match_preflag}\"${flag}${mchar}test${mchar}\" "
     case "$result" in
     *"$match"*)
       $echo "= passed: $result"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]