Re: fix ltdldatafiles corruption bug [libtool--gary--1.0--patch-14]

[Ralf Wildenhues]

* Gary V. Vaughan wrote on Fri, Apr 01, 2005 at 07:40:37PM CEST:
> 
> Okay to commit to HEAD, and backport to branch-2-0?

Makes new tests 1 and 2 fail silently (i.e., they don't work because
they use -I, but report success).

Fixes my `libtoolize' corruption.

>       Getting the value of ltdldatafiles from a submake was not
>       portable, and had problems with GNU make-3.80 at least.  This
>       changeset pulls the installation rules for libtoolize's copy of
>       the libltdl sources out of libltdl/Makefile.am so that
>       ltdldatafiles is defined in the same Makefile that uses it.  Also,
>       this makes a start at cleaning up libltdl/Makefile.am so that it
>       is useful in a package that uses `libtoolize --ltdl':
> 
>       * libltdl/loaders/Makefile.am: Removed entirely.
>       * libltdl/Makefile.am (dlopen.la, dld_link.la, dyld.la)
>       (load_add_on.la, loadlibrary.la, shl_load.la): All built from here
>       now that the loaders submake has gone.
>       (show-ltdldatafiles): Removed.  No longer required.
>       (ltdldatadir, ltdldatafiles, install-local): Moved from here...
>       * Makefile.am (ltdldatadir, ltdldatafiles, install-local): ..to
>       here.
>       (libtoolize): Substitute $(ltdldatafiles) directly without calling
>       make to get the value from libltdl/Makefile.

Please apply.

With this applied, the following test shows some problems: current
`serial' computation is flawed (sorry, I should've checked more
carefully before), as the second libtoolize invocation will copy again.

The "only copies libtool.m4 and ltdl.m4" should be fixed now.  It might
have been a bug of mine not specifying ACLOCAL_AMFLAGS.

Regards,
Ralf

::::::::::::::
Makefile.am
::::::::::::::
ACLOCAL_AMFLAGS = -I m4

::::::::::::::
configure.ac
::::::::::::::
AC_INIT([foo], [1], address@hidden)
AC_CONFIG_HEADERS([config.h:config-h.in])
AC_CONFIG_AUX_DIR([config])
AM_INIT_AUTOMAKE([foreign])
AC_PROG_CC
LT_INIT([dlopen])
LTDL_INIT
AC_CONFIG_FILES([Makefile])
AC_OUTPUT

$ pkgvdatadir=`pwd`/../.. ../libtoolize --copy
$ pkgvdatadir=`pwd`/../.. ../libtoolize --copy --debug
[...]
+ test X1906 = X1906
+ test X1906 = X1906
+ func_verbose '`/tmp/libtool/build-x86_64/foo/../../m4/ltversion.m4'\'' is 
serial 1906, greater than 1.1906 in `m4/ltversion.m4'\'''