libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: [patch] list of input files if max_cmd_len exceeded


From: Ralf Wildenhues
Subject: FYI: [patch] list of input files if max_cmd_len exceeded
Date: Mon, 25 Apr 2005 18:25:16 +0200
User-agent: Mutt/1.4.1i

Hi David,

* David Edelsohn wrote on Fri, Apr 22, 2005 at 06:39:17PM CEST:
>       In addition to the missing _LT_TAGDECL, I found a mistake in the
> previous patch.  I referenced the original name of a variable, $filelist,
> instead of $output.  Sorry for letting that slip through.  Appended is a
> revised patch.

Although I still do not like the way this was solved, I do see that
having only half the solution in is worse than either.  I believe that
the file_list_spec interface is not a good choice, the variable name
does not make its purpose very clear, and it does not easily generalize
to other linkers (e.g. GNU ld).

I have applied this to HEAD, for the first reason stated above.
FWIW, I would not like this in branch-2-0, for the other reasons stated
above.  :-)

BTW: Does our testsuite expose both missing changes?  If not, it would
be nice if you could provide a test.  :)

Regards,
Ralf

>       * m4/libtool.m4 (_LT_LINKER_SHLIBS): _LT_TAGDECL(file_list_spec).
>       * config/ltmain.m4sh (func_mode_link): Change $filelist to $output.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]