Re: inherited linker flags misses linker flags on darwin

[Ralf Wildenhues]

Hi Peter,

* Peter O'Gorman wrote on Mon, Aug 22, 2005 at 03:51:50PM CEST:
> Ralf Wildenhues wrote:
> 
> | I backed out this patch.  It was obviously broken, and I need at least a
> | bit of time to investigate (and do not want bogus bug reports because of
> | this patch causing havoc on !darwin).  For one, a `$' was missing
> | (wonder how I could overlook this on first inspection ;-),
> | for another on !darwin it does not work but harms.
> 
> My fault. Shouldn't try to pack and patch at the same time.

Hehe.  Welcome back from here, too! :)

> I believe this is better.

Better, but look at this:

> +     # Convert "-framework foo" to "foo.ltframework"
> +     if test -n "$inherited_linker_flags"; then
> +       tmp_inherited_linker_flags=`$ECHO "X$inherited_linker_flags" | $Xsed 
> -e 's/-framework \([[^ $]]*\)/\1.ltframework/g'`
> +       for tmp_inherited_linker_flag in $tmp_inherited_linker_flags; do
> +         case " $new_inherited_linker_flags " in
> +           *" tmp_inherited_linker_flag "*) ;;

                 ^
Shouldn't there be a `$' here?  This was what my hint was about.

> +           *) new_inherited_linker_flags="$new_inherited_linker_flags 
> $tmp_inherited_linker_flag";;
> +         esac
> +       done
> +     fi
> +     dependency_libs=`$ECHO "X $dependency_libs" | $Xsed -e 's% \([[^ 
> $]]*\).ltframework% -framework \1%g'`

Cheers,
Ralf