[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: correct erroneous comment for LTDL_CONVENIENCE [libtool--gary--1.0--
From: |
Ralf Wildenhues |
Subject: |
Re: correct erroneous comment for LTDL_CONVENIENCE [libtool--gary--1.0--patch-29] |
Date: |
Mon, 29 Aug 2005 08:37:34 +0200 |
User-agent: |
Mutt/1.4.1i |
* Gary V. Vaughan wrote on Mon, Aug 29, 2005 at 01:09:54AM CEST:
> On 10 May 2005, at 11:45, Ralf Wildenhues wrote:
> >* Gary V. Vaughan wrote on Fri, May 06, 2005 at 07:50:17PM CEST:
> >>Okay to commit to HEAD and branch-2-0?
> >>
> >> * libltdl/m4/ltdl.m4 (LTDL_CONVENIENCE): Fix the comment to not
> >> pretend that LIBLTDL and LTDLINCL are not AC_SUBSTed here.
> >
> >Erm, branch-1-5 does this too, but its docs seem to suggest that the
> >user needs to do this. Do we have compatibility breakage here?
> >Could you check this, please?
>
> This patch is definitely correct for HEAD. In this respect
> branch-1-5 does have the same behaviour as HEAD too.
OK, since AC_SUBSTing the same name twice is allowed, I guess it won't
break user code.
> The documentation in branch-1-5 is misleading. HEAD and branch-1-5
> both do the AC_SUBSTs, but the wording in the docs for HEAD is much
> clearer (I can't find when that happened though). If you approve I'll
> backport this comment patch, and the newer documentation to
> branch-1-5.
Go ahead, please.
Cheers,
Ralf