Re: FYI: set macrodir correctly for installcheck [301]

[Gary V. Vaughan]

Ralf Wildenhues wrote:
> Hi Gary,
>
> * Gary V. Vaughan wrote on Thu, Nov 10, 2005 at 09:06:40PM CET:
>
> > Ralf Wildenhues wrote:
> >
> > > * Gary V. Vaughan wrote on Thu, Nov 10, 2005 at 06:52:45PM CET:
> > >
> > > > Had to tweak slightly to make test-5 work with installcheck.
> > >
> > > Why?  That would be a bug.  The whole point of tst_aclocaldir was that
> > > it does _not_ appear in libtoolize.
> > >
> > > And in fact, over here, this change:
>
>
> > > > +  test -n "$tst_aclocaldir" && aclocaldir="$tst_aclocaldir"
> > >
> > > is not needed at all.
> >
> > Huh?  test 5 can't possibly pass for installcheck without it, because
> > there is no setting for _lt_pkgdatadir in INSTALLCHECK_ENVIRONMENT...
> > I'm all for a cleaner fix than my "tweak" if you have it though! :-)
>
>
> Did you actually see this failure?  If yes, could you please post the
> corresponding testsuite.log failure output?

I certainly *did* see that failure, and made the tst_aclocaldir fix
to prevent that failure...  I don't have time to dig in and understand
*why* it works right now with my fix removed, but it certainly does
work now.  Maybe I dreamt the whole thing...

> For installcheck, the normal pkgdatadir setting in libtoolize should
> just suffice: the files will be installed there.  And, in fact, both
> `installcheck' after `make install' as well as `distcheck' pass here
> without above line.

ACK.

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature