[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: don't add -isysroot to compiler flags if already in $CC
From: |
Ralf Wildenhues |
Subject: |
Re: don't add -isysroot to compiler flags if already in $CC |
Date: |
Mon, 28 Nov 2005 17:41:44 +0100 |
User-agent: |
Mutt/1.5.11 |
Hi Peter,
* Peter O'Gorman wrote on Mon, Nov 28, 2005 at 04:43:44PM CET:
> Hi,
> I had been telling those who asked for years to put -arch flags etc in
> CC/CXX env vars before calling configure. My recent -isysroot patch broke
> the ability to do that, apple's linker rather stupidly dies on some
> duplicate arguments. The only arg I really *need* to eliminate dups of is
> -isysroot, but hey!
Can it ever be useful to add more than one of those?
Like this:
-framework foo -framework bar
If yes, then you should
prev=darwin_framework
framework_arg=$arg
and, in the
darwin_framework)
case, check whether _both_ args match. Even if not: are we going to
remember correctly when we add the next flag here?
Also, I wonder why you leave out CFLAGS and such, so why not check
against $compile_command?
To check against any in-between white space, you'd probably need expr,
as this (SPACE and TAB)
case " $compile_command " in
*" $framework_arg[ ]$arg "*) ;;
*)..
may not be enough?
> Okay?
Dunno either.
Cheers,
Ralf
> 2005-11-28 Peter O'Gorman <address@hidden>
>
> * libltdl/config/ltmain.m4sh [osf1,darwin]: Don't add -model,
> -arch, -isysroot to $compiler_flags if already in $CC with same
> arguments.