libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch: fixup Makefile.in


From: Ralf Wildenhues
Subject: Re: Patch: fixup Makefile.in
Date: Mon, 2 Jan 2006 09:34:05 +0100
User-agent: Mutt/1.5.11

Hi Bob,

* Bob Friesenhahn wrote on Fri, Dec 30, 2005 at 04:33:39PM CET:
> On Fri, 30 Dec 2005, Ralf Wildenhues wrote:
> 
> >>--- libltdl/Makefile.inc    16 Dec 2005 16:36:20 -0000      1.5
> >>+++ libltdl/Makefile.inc    29 Dec 2005 20:24:40 -0000
> >>@@ -27,7 +27,7 @@
> >> # -I$(srcdir) is needed for user that built libltdl with a sub-Automake
> >> # (not as a sub-package!) using 'nostdinc':
> >> AM_CPPFLAGS               += -DLT_CONFIG_H='<$(LT_CONFIG_H)>' \
> >>-                     -DLTDL -I. -I$(srcdir) -Ilibltdl \
> >>+                     -DLTDL -Ilibltdl \
> >
> >This change ignores the comment above it.
> 
> The file contains a number of misleading comments since the comments 
> reflect the origin in Makefile.am and not its use as an Automake 
> include file.

libltdl/Makefile.inc ends up
- included (per Automake `include') in libtool toplevel Makefile.am
- transformed (by rules in toplevel Makefile.am) in libltdl/Makefile.am

and thus in each form of libltdl usage, subpackage (exactly as
libltdl/Makefile.am), nonrecursive and recursive (both versions of
$prefix/share/libtool/libltdl/Makefile.{am,inc}, transformed by
libtoolize).

It is furthermore used in the bootstrap stage for whipping up a dirty
Makefile.

To conclude, above comment is not completely redundant.  It may be
necessary for us to rethink all this machinery, in order to maintain
sanity while fixing all the bugs you've reported (and remaining bugs,
too, of course).  Let's see.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]