[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: test failures
From: |
Ralf Wildenhues |
Subject: |
Re: test failures |
Date: |
Thu, 26 Oct 2006 22:39:12 +0200 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Hello Patrick,
Thanks for the report.
* Patrick Welche wrote on Thu, Oct 26, 2006 at 04:37:39PM CEST:
> All with CVS autotools, the following tests fail for me:
>
> 16: link-order2.at:25 Link order of deplibs.
> libtool
This one is different and will be treated later.
All the others are missing a config header, which is required since
recently. I forgot to adjust the tests, as they did not show up as
failures on GNU/Linux: it doesn't need argz.c. So let's remove the
check on lt__alloc.c as well, that way the failure is obvious on all
systems.
I've applied the patch below.
Cheers,
Ralf
2006-10-26 Ralf Wildenhues <address@hidden>
Assume presence of a config header in all files, to provoke
test failures on all systems.
* libltdl/lt__alloc.c: Likewise.
* libltdl/libltdl/lt__dirent.h: Likewise.
* libltdl/libltdl/lt__glibc.h: Likewise.
* libltdl/libltdl/lt__private.h: Likewise.
* libltdl/libltdl/lt__strl.h: Likewise.
* tests/recursive.at: Use AC_CONFIG_HEADERS.
* tests/nonrecursive.at: Likewise. Invoke autoheader.
* HACKING: Adjust.
Report by Patrick Welche.
Index: HACKING
===================================================================
RCS file: /cvsroot/libtool/libtool/HACKING,v
retrieving revision 1.30
diff -u -r1.30 HACKING
--- HACKING 30 Aug 2006 03:18:15 -0000 1.30
+++ HACKING 26 Oct 2006 19:15:33 -0000
@@ -291,17 +291,13 @@
to various system libc interfaces that differ between hosts supported
by libtool. Typically, the files that implement this layer begin:
- #ifdef HAVE_CONFIG_H
- # if defined(LT_CONFIG_H)
- # include LT_CONFIG_H
- # else
- # include <config.h>
- # endif
+ #if defined(LT_CONFIG_H)
+ # include LT_CONFIG_H
+ #else
+ # include <config.h>
#endif
#include "lt_system.h"
- The `ifdef HAVE_CONFIG_H' helps facilitate code sharing with gnulib.
-
Or if they are installed headers that must work outside the libtool
source tree, simply:
Index: libltdl/lt__alloc.c
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/lt__alloc.c,v
retrieving revision 1.8
diff -u -r1.8 lt__alloc.c
--- libltdl/lt__alloc.c 4 Sep 2006 17:27:26 -0000 1.8
+++ libltdl/lt__alloc.c 26 Oct 2006 19:15:33 -0000
@@ -27,12 +27,10 @@
*/
-#ifdef HAVE_CONFIG_H
-# if defined(LT_CONFIG_H)
-# include LT_CONFIG_H
-# else
-# include <config.h>
-# endif
+#if defined(LT_CONFIG_H)
+# include LT_CONFIG_H
+#else
+# include <config.h>
#endif
#include <stdio.h>
Index: libltdl/libltdl/lt__dirent.h
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/libltdl/lt__dirent.h,v
retrieving revision 1.5
diff -u -r1.5 lt__dirent.h
--- libltdl/libltdl/lt__dirent.h 28 Aug 2006 16:02:14 -0000 1.5
+++ libltdl/libltdl/lt__dirent.h 26 Oct 2006 19:15:33 -0000
@@ -30,12 +30,10 @@
#if !defined(LT__DIRENT_H)
#define LT__DIRENT_H 1
-#ifdef HAVE_CONFIG_H
-# if defined(LT_CONFIG_H)
-# include LT_CONFIG_H
-# else
-# include <config.h>
-# endif
+#if defined(LT_CONFIG_H)
+# include LT_CONFIG_H
+#else
+# include <config.h>
#endif
#include "lt_system.h"
Index: libltdl/libltdl/lt__glibc.h
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/libltdl/lt__glibc.h,v
retrieving revision 1.6
diff -u -r1.6 lt__glibc.h
--- libltdl/libltdl/lt__glibc.h 4 Sep 2006 17:21:35 -0000 1.6
+++ libltdl/libltdl/lt__glibc.h 26 Oct 2006 19:15:33 -0000
@@ -30,12 +30,10 @@
#if !defined(LT__GLIBC_H)
#define LT__GLIBC_H 1
-#ifdef HAVE_CONFIG_H
-# if defined(LT_CONFIG_H)
-# include LT_CONFIG_H
-# else
-# include <config.h>
-# endif
+#if defined(LT_CONFIG_H)
+# include LT_CONFIG_H
+#else
+# include <config.h>
#endif
#if !defined(HAVE_ARGZ_H)
Index: libltdl/libltdl/lt__private.h
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/libltdl/lt__private.h,v
retrieving revision 1.9
diff -u -r1.9 lt__private.h
--- libltdl/libltdl/lt__private.h 30 Aug 2006 04:14:21 -0000 1.9
+++ libltdl/libltdl/lt__private.h 26 Oct 2006 19:15:33 -0000
@@ -30,12 +30,10 @@
#if !defined(LT__PRIVATE_H)
#define LT__PRIVATE_H 1
-#ifdef HAVE_CONFIG_H
-# if defined(LT_CONFIG_H)
-# include LT_CONFIG_H
-# else
-# include <config.h>
-# endif
+#if defined(LT_CONFIG_H)
+# include LT_CONFIG_H
+#else
+# include <config.h>
#endif
#include <stdio.h>
Index: libltdl/libltdl/lt__strl.h
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/libltdl/lt__strl.h,v
retrieving revision 1.5
diff -u -r1.5 lt__strl.h
--- libltdl/libltdl/lt__strl.h 28 Aug 2006 16:02:14 -0000 1.5
+++ libltdl/libltdl/lt__strl.h 26 Oct 2006 19:15:33 -0000
@@ -30,12 +30,10 @@
#if !defined(LT__STRL_H)
#define LT__STRL_H 1
-#ifdef HAVE_CONFIG_H
-# if defined(LT_CONFIG_H)
-# include LT_CONFIG_H
-# else
-# include <config.h>
-# endif
+#if defined(LT_CONFIG_H)
+# include LT_CONFIG_H
+#else
+# include <config.h>
#endif
#include <string.h>
Index: tests/nonrecursive.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/nonrecursive.at,v
retrieving revision 1.7
diff -u -r1.7 nonrecursive.at
--- tests/nonrecursive.at 16 Dec 2005 16:15:32 -0000 1.7
+++ tests/nonrecursive.at 26 Oct 2006 19:15:33 -0000
@@ -27,6 +27,7 @@
AC_CONFIG_AUX_DIR([ltdl/config])
AC_CONFIG_MACRO_DIR([ltdl/m4])
AC_CONFIG_LIBOBJ_DIR([ltdl])
+AC_CONFIG_HEADERS([config.h:config.hin])
AM_INIT_AUTOMAKE([foreign subdir-objects])
AC_PROG_CC
AM_PROG_CC_C_O
@@ -79,7 +80,7 @@
cp ltdl/$file $file
done
-LT_AT_BOOTSTRAP([ignore], [-I ltdl/m4], [ignore], [--add-missing --copy],
+LT_AT_BOOTSTRAP([ignore], [-I ltdl/m4], [], [--add-missing --copy],
[], [], [all $tst_dist])
AT_CHECK([test -f ltdl/libltdlc.la])
@@ -103,7 +104,7 @@
cp ltdl/$file $file
done
-LT_AT_BOOTSTRAP([ignore], [-I ltdl/m4], [ignore], [--add-missing --copy],
+LT_AT_BOOTSTRAP([ignore], [-I ltdl/m4], [], [--add-missing --copy],
[], [], [all $tst_dist])
AT_CHECK([test -f ltdl/libltdlc.la])
@@ -129,7 +130,7 @@
cp ltdl/$file $file
done
-LT_AT_BOOTSTRAP([ignore], [-I ltdl/m4], [ignore], [--add-missing --copy],
+LT_AT_BOOTSTRAP([ignore], [-I ltdl/m4], [], [--add-missing --copy],
[], [--enable-ltdl-install --prefix=$prefix], [all install $tst_dist])
AT_CHECK([test -f $prefix/lib/libltdl.la])
Index: tests/recursive.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/recursive.at,v
retrieving revision 1.4
diff -u -r1.4 recursive.at
--- tests/recursive.at 16 Dec 2005 16:15:32 -0000 1.4
+++ tests/recursive.at 26 Oct 2006 19:15:33 -0000
@@ -27,6 +27,7 @@
AC_CONFIG_AUX_DIR([ltdl/config])
AC_CONFIG_MACRO_DIR([ltdl/m4])
AC_CONFIG_LIBOBJ_DIR([ltdl])
+AC_CONFIG_HEADERS([config.h:config.hin])
AM_INIT_AUTOMAKE([foreign])
LT_INIT
LT_WITH_LTDL
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: test failures,
Ralf Wildenhues <=