[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: silence m4 --warn-syntax warning
From: |
Ralf Wildenhues |
Subject: |
Re: silence m4 --warn-syntax warning |
Date: |
Mon, 29 Jan 2007 19:43:08 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Hello Eric,
Thanks for your work.
* Eric Blake wrote on Mon, Jan 29, 2007 at 03:07:04PM CET:
> 2007-01-29 Eric Blake <address@hidden>
>
> * libltdl/m4/libtool.m4 (_LT_PROG_ECHO_BACKSLASH): Avoid issues
> with m4-1.4.9 --warn-syntax.
> (_LT_PROG_XSI_SHELLFNS): Likewise.
Extra bonus if you port to branch-1-5 as well, and if you kill all
now-superfluous curly braces that were only introduced to keep M4
away. For example, this:
> - case ${1} in
> - */*) func_dirname_result="${1%/*}${2}" ;;
> - * ) func_dirname_result="${3}" ;;
> + case [$]{1} in
> + */*) func_dirname_result="[$]{1%/*}[$]{2}" ;;
> + * ) func_dirname_result="[$]{3}" ;;
can be simplified to this:
case [$]1 in
*/*) func_dirname_result="[$]{1%/*}[$]2" ;;
* ) func_dirname_result="[$]3" ;;
but also I'd prefer to follow `(autoconf.info)Coding Style' and then
write this:
case $[1] in
*/*) func_dirname_result="[$]{1%/*}$[2]" ;;
* ) func_dirname_result="$[3]" ;;
Ahh. See how the coding style now comes out inconsistent?
So let's go back there and address that first, before we do
anything about Libtool. (Continued in the respective thread
on autoconf-patches.)
Cheers,
Ralf