Re: [3/11] Native MSVC support (msvc-cwrapper)

[Peter Rosin]

On Sat, Jul 21, 2007 at 06:51:47AM -0400, Charles Wilson wrote:
> Peter Rosin wrote:
> >On Thu, Jul 19, 2007 at 05:47:36PM -0400, Charles Wilson wrote:
> >The cwrapper has two targets (cygwin, mingw), I'm adding a third (msvc).
> >Both the previous targets has stat as stat, cygwin doesn't have _stat
> >and msvc doesn't have stat (unless you link with OLDNAMES.LIB).
> >
> >So, going the other way around breaks cygwin (IIRC). 
> 
> How can it break cygwin?

*snip*

Err, my bad. I assumed I was not stupid and didn't reread carefully
enough. Did anyone else notice that the define is the wrong way
around? :-)

What I meant in my previos mail was that the only point of having the
define the wrong way around would be to ALSO change the code from
stat to _stat. And that would surely break cygwin...

Anyway, I don't remember how the bogus define was ever added and why
I never detected its noop-ness, I intended it to be
        #define stat _stat
all along. The fact that it works the wrong way around is that
stat is available #if !__STDC__. So I'm going to commit with
the intended define. Works with MSVS 6, 2003 and 2005.

Thank you all for reviews, feedback, etc...

Cheers,
Peter