libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: unused variable in chase_symlinks


From: Charles Wilson
Subject: Re: unused variable in chase_symlinks
Date: Sun, 22 Jul 2007 22:57:42 -0400
User-agent: Thunderbird 1.5.0.12 (Windows/20070509)

Eric Blake wrote:
On cygwin, I'm getting a lot of these warnings (on CVS head M4, one for
each of the 42 gnulib tests):

 creating test-isnanl-nolibm.exe
./.libs/lt-test-isnanl-nolibm.c: In function `chase_symlinks':
./.libs/lt-test-isnanl-nolibm.c:499: warning: unused variable `rv'

due to unused code being generated by libtool. OK to commit?

OK by me.

Also,
ltmain.m4sh has a lot of whitespace problems (space-tab and end-of-line
whitespace) that emacs flagged, is it okay to fix that in a separate commit?

Well, be very careful in func_emit_cwrapperexe_src(). I worked hard to ensure the emitted C code obeys GNU Coding Standards, and I'd hate to see that destroyed because Emacs' rules on formatting differ for "shell" code.

OTOH, the lack of consistency (esp. space-tab) throughout ltmain.m4sh has bugged me for a while, so I'd welcome improvements in that area.

P.S. Does CVS m4 actually work on cygwin, now, if you've reached the point of worrying about compiler warnings?

--
Chuck




reply via email to

[Prev in Thread] Current Thread [Next in Thread]