|
From: | Gary V. Vaughan |
Subject: | Re: [PATCH 363] Allow better compile time type checking for lt_dladvise |
Date: | Sun, 20 Apr 2008 21:22:18 -0400 |
Howdy Bob! On 20 Apr 2008, at 21:13, Bob Friesenhahn wrote:
On Sun, 20 Apr 2008, Gary V. Vaughan wrote:* libltdl/lt__private.h (lt__handle, lt__advise): Typedefs removed in favour of... * libltdl/ltdl.h (lt_dlhandle), libltdl/libltdl/lt_dlloader.h (lt_dladvise): ...changing from void* to forward declarations. * libltdl/loaders/dlopen.c, libltdl/loaders/loadlibrary.c, libltdl/lt_dlloader.c, libltdl/ltdl.c: Remove many redundant type casts. * NEWS: Updated. Suggested by Bob Friesenhahn <address@hidden>I like this very much. Besides helping user code, it should diminish the number of compiler warnings when compiling libltdl and may even avoid some optimization-related bugs.
Is that a review with an implicit "please apply"? Or are you just cheering me on from the sidelines :-)
Cheers, Gary -- ())_. Email me: address@hidden ( '/ Read my blog: http://blog.azazil.net / )= ...and my book: http://sources.redhat.com/autobook `(_~)_
PGP.sig
Description: This is a digitally signed message part
[Prev in Thread] | Current Thread | [Next in Thread] |