[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 365] Only complain that files are up-to-date with --force.
|
From: |
Ralf Wildenhues |
|
Subject: |
Re: [PATCH 365] Only complain that files are up-to-date with --force. |
|
Date: |
Wed, 23 Apr 2008 07:33:15 +0200 |
|
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
* Gary V. Vaughan wrote on Wed, Apr 23, 2008 at 12:18:39AM CEST:
> On 22 Apr 2008, at 16:16, Ralf Wildenhues wrote:
>
>>> + eval $1=""
>>
>> Those double quotes are pretty superfluous, as they won't survive the
>> eval. Not that they are a problem at all. :-)
>
> I quite like the fact that the say to the reader: "this variable is
> being set to the empty string",
Yes, I know. What you meant to write was
eval $1=\"\"
> so I'm inclined to leave them.
My point is that it's not helpful trying to help the naive reader
and confusing the slightly less naive one.
Cheers,
Ralf