libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libltdl and cygwin 1.7.0


From: Eric Blake
Subject: Re: libltdl and cygwin 1.7.0
Date: Wed, 30 Apr 2008 17:30:51 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Bob Friesenhahn <bfriesen <at> simple.dallas.tx.us> writes:

`cygwin_conv_to_full_win32_path' is
> > deprecated (declared at /usr/include/sys/cygwin.h:52)
> >
> > OK to apply?
> 
> This looks good to apply to me except for the minor nit that the 
> bracing indentation within the HAVE_DECL_CYGWIN_CONV_PATH is wrong 
> (and should be corrected).
> 
> > -#if defined(__CYGWIN__)
> > +#if HAVE_DECL_CYGWIN_CONV_PATH
> > +      if (cygwin_conv_path (CCP_POSIX_TO_WIN_A, filename, wpath, MAX_PATH))
> > +        {
> > +     LT__SETERROR (CANNOT_OPEN);
> > +     return 0;
> > +   }

Oops - tab vs. 8 spaces.  Fixed (to consistent tab usage) and committed; thanks 
for the review.

-- 
Eric Blake







reply via email to

[Prev in Thread] Current Thread [Next in Thread]