libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] allow unquoted "test $?"


From: Ralf Wildenhues
Subject: Re: [PATCH] allow unquoted "test $?"
Date: Thu, 31 Jul 2008 19:46:53 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

* Paolo Bonzini wrote on Thu, Jul 31, 2008 at 01:43:18PM CEST:
> With git libtool, sh.test is failing.  Either the offending line should  
> be fixed, or the attached patch to sh.test should be applied to allow  
> not quoting $?.

Let's just fix the offending line.

Thanks,
Ralf

2008-07-31  Ralf Wildenhues  <address@hidden>

        * libltdl/config/ltmain.m4sh (func_to_host_path): Fix sh.test
        failure.
        Report by Paolo Bonzini.

diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index b6fb29b..a3b2c71 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -2563,7 +2563,7 @@ func_to_host_path ()
             # error code of zero AND non-empty stdout, which explains
             # the odd construction:
             func_to_host_path_tmp1=`winepath -w "$1" 2>/dev/null`
-            if test $? -eq 0 && test -n "${func_to_host_path_tmp1}"; then
+            if test "$?" -eq 0 && test -n "${func_to_host_path_tmp1}"; then
               func_to_host_path_result=`echo "$func_to_host_path_tmp1" |\
                 $SED -e "$lt_sed_naive_backslashify"`
             else




reply via email to

[Prev in Thread] Current Thread [Next in Thread]