Re: [SCM] GNU Libtool branch, master, updated. v2.2.4-43-gcbe0c8e

[Ralf Wildenhues]

[ moving from libtool-commit ]

Hi Gary,

a couple of nits.  Note that I currently don't feel the need for
a commit script, as we have commit messages enabled through git
anyway.  But if it suits you...

* Gary V. Vaughan wrote on Sat, Sep 06, 2008 at 08:41:55PM CEST:
> - Log -----------------------------------------------------------------
> commit cbe0c8e417016a7e05b391bc4b9ee1999708bf33
> Author: Gary V. Vaughan <address@hidden>
> Date:   Sun Sep 7 02:41:39 2008 +0800
> 
>     Make ./commit useful again.
>     * clcommit.m4sh: Major overhaul and simplification for git.
>     
>     Signed-off-by: Gary V. Vaughan <address@hidden>

[...]
> @@ -209,11 +207,11 @@ set -e
>                       fi
>                       # The funny quoting allows keeping one option per
>                       # line in $rc_file:
> -                     eval set dummy `echo \`cat $rc_file\` 
> \\\${1+\"address@hidden"}`
> +                     eval set dummy $(echo $(cat $rc_file) 
> \\\${1+\"address@hidden"})

This looks wrong.  `...` requires backslash-dancing, $(...) doesn't.
But anyway I don't understand why you don't just make this something
like
        eval set dummy $(echo $(cat $rc_file)) '${1+"$@"}'

or even (but this may drop some expansion you're interested in):

        eval set dummy $(cat $rc_file) '${1+"$@"}'


> @@ -303,27 +289,9 @@ set -e
>  # func_check_conflicts
>  func_check_conflicts ()
>  {

> +    # HELP?!?  How to check for git push conflicts?

Not sure why needed.  git push will not, unless you force it, push
something that is not a fast-forward of the remote tree.

> +    if false; then
> +      func_fatal_error "some conflicts were found with CVS repository, 
> aborting..."
>      fi
>  }

Cheers,
Ralf