libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Make -Wc,foo behave like -Xcompiler foo in link mode.


From: Ralf Wildenhues
Subject: Re: Make -Wc,foo behave like -Xcompiler foo in link mode.
Date: Fri, 4 Sep 2009 19:44:47 +0200
User-agent: Mutt/1.5.20 (2009-08-09)

Hello Peter,

* Peter Rosin wrote on Fri, Sep 04, 2009 at 12:38:48PM CEST:
>       Make -Wc,foo behave like -Xcompiler foo in link mode.
>       * libltdl/config/ltmain.m4sh (func_mode_link): Remove "-Wc,"
>       instead of replacing it with "$wl".

This patch is ok, but please state clearly that this affects linking
of programs only, not linking of libraries, and restores consistency
of the former with respect to the latter (not sure if this is a
regression).  Also, it needs a NEWS entry.

Further, the patch needs a testsuite addition, but I can do that later
if you don't want to.  I was thinking of a new set of tests flags.at and
running a bunch of
  libtool -n --mode=X ... $flag-foo

for $flag in -Wl, -Wc, '-Xcompiler ' and '-Xlinker ', both library and
program output, and grepping the output for ${wl}-foo and similar (I
don't remember whether that was general enough for all compilers, you
know w32 better).

Thanks,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]