Re: [PATCH] [cygwin] Refactor C++ exception handling for Win32 correctness

[Ralf Wildenhues]

* Charles Wilson wrote on Sun, Jun 20, 2010 at 06:59:02AM CEST:
> There are ODR issues with the definition of the exception class(es).
> While on linux, the code may technically be in violation, in practice
> it is ok and works.

But that's not OK.  As much as possible, we want our tests to abide by
the relevant standards, the C++ one here.  We want tests to work on all
conforming platforms, not just those we happen to test right now[1].
There is no need to word the comment before the test in a way that
frames it as a pure w32 thing if it isn't:

> +# However, for simplicity, the refactoring of modexc into a separate
> +# library is done for all platforms.

This can go.  Please mention in the comment that not using a common lib
represents an ODR violation (mentioning relevant terms from standards is
helpful).

BTW, does not using the same strategy for liba represent an ODR
violation as well?  If yes, then we should fix that, too.

> OK to push?

Given above comments are addressed, and there are no objections from
others within 48 hours, yes.

Thanks,
Ralf

[1] And I specifically don't want to see them break with LTO, just
    because we got away with some violation before.