Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.

[Gary V. Vaughan]

Hi Chuck,

On 22 Jun 2010, at 19:10, Charles Wilson wrote:

On 6/22/2010 7:54 AM, Gary V. Vaughan wrote:

But compile_tag is never set, so the patch is a NOP!

If that happens with a later patch in your series, please roll all

the compile_tag machinery into a single commit.

But what if that later patch, in order to work correctly, also requires

additional prep work?  You're possibly opening up a spiderweb of

inter-dependencies between patches.

I could easily see a series of "nop" patches, each of which is small and

easily reviewed in isolation, but all of which are necessary for a

single, final "do it" patch.  You might be asking, in effect, for "do

it" + "all the nops" to be rolled together and presented at once -- in

a large, complex, difficult to review patch.

Peter has already split his mega patch into small, easily digestible

chunks with minimal inter-dependencies. Let's not second guess his

decomposition...

That's a good point.  But on the other side of the coin I don't want
to blindly "okay" a series of NOP patches into master without understanding
first where we are going.

In this case, Peter, would you point me at the followup patches that need
this preliminary prep work?  I had a poke around in your git branch but
couldn't (quickly) figure out where this is going... and without that it's
hard to do a sane review.

Cheers,
-- 
Gary V. Vaughan (address@hidden)