libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Set library search path empty in dlloader-api test.


From: Peter Rosin
Subject: Re: [PATCH] Set library search path empty in dlloader-api test.
Date: Fri, 25 Jun 2010 01:26:59 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5

Hi Chuck,

Den 2010-06-25 00:50 skrev Charles Wilson:
On 6/20/2010 2:31 AM, Charles Wilson wrote:
Tested on cygwin, mingw, linux, and works. But, given the issues
raised above...comments? discussion? Additional testing on esoteric
platforms? OK to push?

NOTE: From the autoconf manual:
   Posix prefers `setenv' to `putenv'; among other things, `putenv'
   is not required of all Posix implementations, but `setenv' is.
Unfortunately, MinGW and MSVC do not provide setenv but DO provide
_putenv.  Unless we want to extend the test using a custom
setenv implementation in terms of putenv for these two platforms,
(as done in the cwrapper code), and otherwise use setenv...this
seems simpler. But if we really CAN'T rely on putenv's presence...

Maybe uglification is the better way to go for this issue.
Ping?

Ooops, sorry. As the original author of the test I meant to comment
on this, but sadly forgot about it. I was under the impression that
when I fed "last" to ltdl it would come back as "last" regardless
of any files in the file system. This is obviously not the case.
Since what I wanted to test was that the "last" module was really
last in the chain of modules, not some strange file system
interaction, I tend to think that it would be much easier to uglify
the module name "last" (and as a part of that also make sure to
prepend a slash as that wouldn't break the test, right?).

Zapping with the search path seems overly complicated and will
not represent anything even remotely normal.

But all this is just my opinion of course.

Cheers,
Peter



reply via email to

[Prev in Thread] Current Thread [Next in Thread]