[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add an XSI replacement for func_split_short_opt.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Add an XSI replacement for func_split_short_opt. |
Date: |
Sun, 27 Jun 2010 14:02:15 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 12:58:03PM CEST:
> Okay to push?
No, ${parameter:offset} and ${parameter:offset:length} are bash specific
not XSI mandated. IIRC we already have a separate test for bash
features that won't regress on non-bash XSI shells. Please add the test
there. Then, the patch is ok if you have ensured that our testsuite
covers the code path (i.e., tries a short option that needs splitting
this way) or added it there, help.at would be a good place. And tested
on one system that has a good shell and one that has a bad shell.
Thanks!
Ralf
> * libltdl/m4/libtool.m4 (_LT_CHECK_SHELL_FEATURES): Also ensure
> that XSI substring extraction is supported.
> (_LT_PROG_XSI_SHELLFNS): Use XSI substring extraction to split
> short options to avoid unnecessary forks if the host shell
> supports that.
- [PATCH] Add an XSI replacement for func_split_short_opt., Gary V. Vaughan, 2010/06/27
- Re: [PATCH] Add an XSI replacement for func_split_short_opt.,
Ralf Wildenhues <=
- Re: [PATCH] Add an XSI replacement for func_split_short_opt., Gary V. Vaughan, 2010/06/27
- Re: [PATCH] Add an XSI replacement for func_split_short_opt., Eric Blake, 2010/06/28
- Re: [PATCH] Add an XSI replacement for func_split_short_opt., Ralf Wildenhues, 2010/06/28
- Re: [PATCH] Add an XSI replacement for func_split_short_opt., Eric Blake, 2010/06/28
- Re: [PATCH] Add an XSI replacement for func_split_short_opt., Gary V. Vaughan, 2010/06/29
- Re: [PATCH] Add an XSI replacement for func_split_short_opt., Paolo Bonzini, 2010/06/29
- Re: [PATCH] Add an XSI replacement for func_split_short_opt., Gary V. Vaughan, 2010/06/29
- Re: [PATCH] Add an XSI replacement for func_split_short_opt., Eric Blake, 2010/06/29
- Re: [PATCH] Add an XSI replacement for func_split_short_opt., Gary V. Vaughan, 2010/06/29
- Re: [PATCH] Add an XSI replacement for func_split_short_opt., Ralf Wildenhues, 2010/06/29