|
From: | Peter Rosin |
Subject: | Re: [PATCH] Add func_append_quoted and do inline func_append substitutions. |
Date: | Thu, 01 Jul 2010 19:25:02 +0200 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5 |
Hi Gary! Den 2010-06-28 01:24 skrev Gary V. Vaughan:
Looking through the XSI substitutions, or more correctly the bash/ksh func_append usage, there's room here to consistently use func_append everywhere to make for easier maintenance... but rather than take the additional overhead of a function call in the sensitive quadratic scaling parts that prompted the introduction of the += idiom in the first place: use the libtool rewriting machinery to substitute inline `+=' where possible, with a fallback to the earlier longhand otherwise. Okay to push? @@ -6569,7 +6572,7 @@ EOF *) case " $deplibs " in *" -L$path/$objdir "*) - new_libs="$new_libs -L$path/$objdir" ;; + func_append new_libs "_libs -L$path/$objdir" ;; esac ;; esac
This hunk is royally hosed. I pushed the following as obvious... Cheers, Peter 2010-07-01 Peter Rosin <address@hidden> Fix regression caused by "Add func_append_quoted and do..." * libltdl/config/ltmain.m4sh (func_mode_link): Remove leftover "_libs" trash. diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 760b6aa..e5b68af 100644 --- a/libltdl/config/ltmain.m4sh +++ b/libltdl/config/ltmain.m4sh @@ -6572,7 +6572,7 @@ EOF *) case " $deplibs " in *" -L$path/$objdir "*) - func_append new_libs "_libs -L$path/$objdir" ;; + func_append new_libs " -L$path/$objdir" ;; esac ;; esac
[Prev in Thread] | Current Thread | [Next in Thread] |