libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFT PATCH v4 0/8] Sysroot series


From: Paolo Bonzini
Subject: Re: [RFT PATCH v4 0/8] Sysroot series
Date: Sun, 01 Aug 2010 21:14:14 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5

On 08/01/2010 08:43 PM, Ralf Wildenhues wrote:
* Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:26PM CEST:
   handle sysroot flags
   add --with-sysroot
   teach libtool -L= and -R=
   handle sysrooted paths when reading dependencies to la files
   process postdeps to include sysrooted paths
   emit sysrooted paths when installing .la files
   add sysroot test
   initial version of the NEWS entry

The overall series looks fairly good to me, thanks to you and Charles
for the hard work on it.  Please s/2009/2010/ in the new testsuite file,
and spaces before open parentheses for C and shell functions, thanks.

Thanks.

After nits have been addressed, also please feel free to push the patch
series to a temporary git branch (off of master) on savannah.  I expect
that it will be mergeable with minor corrections.  I really do think
however that a libtool.texi update would be fairly important to have.

Also, I still don't quite understand why this is unusable when the
compiler is not sysrooted, so an explanation would be nice.  For
example, the w32 cross compiler package on Debian is not sysrooted.

Because we cannot transform sysroot-based paths if we don't know the sysroot. Actually, I think --with-sysroot=... would work but I have to test it.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]