Re: [RFT PATCH v3 3/9] add --with-sysroot

[Paolo Bonzini]

On 08/01/2010 12:48 PM, Ralf Wildenhues wrote:
> Actually, I don't see any other uses of target in the whole patch
> series, so why not just omit that here?

All of this is dead code actually...

> > +   AC_MSG_RESULT([$with_sysroot])
> > +   lt_sysroot=`echo "$with_sysroot" | sed -e "$sed_quote_subst"`
> > +   ;; #(
> > + no)
>
> Normalization of "no" to empty?  The rest of the series doesn't
> special-case "no", and I think empty would please GCC configury, too
> (untested).

> I'm not sure how to address these (not even sure
> they use Libtool) except for a big sign in NEWS, and documentation in
> the manual.

I can think of two ways:

1) ignore --with-sysroot if not cross-compiling.  This however has a 
problem: if we test $cross_compiling = yes, sysroot tests will fail 
under Wine.

2) support both --with-sysroot and --with-host-sysroot, with the latter 
overriding the first.  Make GCC's toplevel always pass 
--without-host-sysroot to build modules, always pass 
--without-host-sysroot unless it was specified for host modules (this 
serves Canadian crosses), and skip --with-host-sysroot for target 
modules.  This is a hack, but one that can work reliably.

Paolo