Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

[Ralf Wildenhues]

* Gary V. Vaughan wrote on Sun, Aug 08, 2010 at 08:50:12AM CEST:
> On 7 Aug 2010, at 18:15, Ralf Wildenhues wrote:
> > <http://lists.gnu.org/archive/html/libtool-patches/2010-06/msg00190.html>

> I don't see that the +=/func_append substitution is causing any additional
> concerns to the XSI function substitution though. The whole function
> substitution is really a single issue in this case, right?  Either we need
> to work on it to the point where it will DTRT reliably, or else we should
> remove all of the function substitution machinery, and go back to writing
> portable shell everywhere.

Agreed, but bugs can always happen.

> I'd rather not do that actually, but I don't have time to work on getting
> timings or looking at bugs right now, so I'm more than happy to leave the
> decision in your capable hands.

Thanks; I'm still undecided, but measurements of
  make check-local TESTSUITEFLAGS='-k libtool'

cannot detect a performance impact in the noise.  There can still be one
with another workload, of course.

I think we should have a rule to not apply pure optimization patches
without measurement results.

Cheers,
Ralf