Re: another func_append inlining regression

[Ralf Wildenhues]

* Ralf Wildenhues wrote on Mon, Aug 09, 2010 at 10:55:25PM CEST:
> Note the double colon after -blibpath, which is due to a regression in
> v2.2.10-40-g0da7d80 fixed with the patch below.  I wish I'd never
> approved that patch, this one took me so long to find ...

I did a re-review of that patch, and found more issues: the shell
doesn't do word splitting on the RHS of an assignment, but does do so
with function call arguments.  Fixed as follows.

Cheers,
Ralf

    Fix more problematic code from "Add func_append_quoted and do..."
    
    * libltdl/config/ltmain.m4sh (func_mode_link): Revert back
    func_append instances that as assignments relied on the shell
    not performing word splitting on the right hand side of the
    assignment.

diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index e5065fb..d677529 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -2464,7 +2464,7 @@ func_extract_archives ()
         func_extract_an_archive "$my_xdir" "$my_xabs"
        ;;
       esac
-      func_append my_oldobjs " "`find $my_xdir -name \*.$objext -print -o 
-name \*.lo -print | sort | $NL2SP`
+      my_oldobjs="$my_oldobjs "`find $my_xdir -name \*.$objext -print -o -name 
\*.lo -print | sort | $NL2SP`
     done
 
     func_extract_archives_result="$my_oldobjs"
@@ -5854,7 +5854,7 @@ func_mode_link ()
          compile_deplibs="$new_inherited_linker_flags $compile_deplibs"
          finalize_deplibs="$new_inherited_linker_flags $finalize_deplibs"
        else
-         func_append compiler_flags " "`$ECHO " $new_inherited_linker_flags" | 
$SED 's% \([^ $]*\).ltframework% -framework \1%g'`
+         compiler_flags="$compiler_flags "`$ECHO " 
$new_inherited_linker_flags" | $SED 's% \([^ $]*\).ltframework% -framework 
\1%g'`
        fi
       fi
       dependency_libs="$newdependency_libs"