Re: [PATCH v2 3/4] reorganize parsing of --mode=finish arguments

[Ralf Wildenhues]

* Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:05AM CEST:
> * libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for
> directories and *.la files.  Add .la files for all directories.

Ah, there's another nit.

> --- a/libltdl/config/ltmain.m4sh
> +++ b/libltdl/config/ltmain.m4sh
> @@ -1397,15 +1397,28 @@ test "$opt_mode" = execute && func_mode_execute 
> ${1+"$@"}
>  func_mode_finish ()
>  {
>      $opt_debug
> -    libdirs="$nonopt"
> +    libs=
> +    libdirs=
>      admincmds=
>  
> -    if test -n "$finish_cmds$finish_eval" && test -n "$libdirs"; then
> -      for dir
> -      do
> -     func_append libdirs " $dir"
> -      done
> +    for opt in "$nonopt" "$@"

This should be "$nonopt" ${1+"$@"} because you might not have any
arguments in $@ any more.

> +    do
> +      if test -d "$opt"; then
> +     func_append libdirs " $opt"
> +
> +      elif test -f "$opt"; then
> +     if func_lalib_unsafe_p "$opt"; then
> +       func_append libs " $opt"
> +     else
> +       func_warning "\`$opt' is not a valid libtool archive"
> +     fi
> +
> +      else
> +     func_fatal_error "invalid argument \`$opt'"
> +      fi
> +    done