Re: [PATCH] Factor the sed command used to make a regex from a literal.

[Ralf Wildenhues]

* Paolo Bonzini wrote on Sun, Aug 15, 2010 at 07:06:25PM CEST:
> In func_generate_dlsyms, the resulting regex is used with grep rather
> than sed.  I don't think grep has problems with \/ in practice, but of
> course I can change it to use sed, too.

Oh, I managed to overlook that.  In that case, sorry about my bad
suggestions.  \/ is undefined behavior for grep according to SUSv3,
I'd prefer to not delve into that territory any more than we have to,
somebody might come along and invent posix-hard-sed and file bug
reports with all nonconforming tools (hello, posh!).

> Ok? (if so, which way?)

I'd prefer if you drop the func_generate_dlsyms hunk, there's no bug to
be fixed here.  We can keep the rest though, in time the sed script will
be used elsewhere.

Thanks,
Ralf

> 2010-08-15  Paolo Bonzini  <address@hidden>
> 
>         * libltdl/config/general.m4sh (sed_make_literal_regex): New.
>         * libltdl/config/ltmain.m4sh (func_generate_dlsyms,

FWIW, I think GCS style is
        * file-name (function-name)
        (function-name, ...):

i.e., close and reopen parens at EOL.

>         func_cygming_dll_for_implib_fallback_core): Use it.  Suggested
>         by Ralf Wildenhues.