libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

tests: avoid spurious test failure due to library mode on HP-UX.


From: Ralf Wildenhues
Subject: tests: avoid spurious test failure due to library mode on HP-UX.
Date: Thu, 2 Sep 2010 21:17:51 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

http://autobuild.josefsson.org/libtool/log-201008291316534087000.txt

| ../../libtool/tests/help.at:164: $orig_LIBTOOL --mode=install cp liba.la 
libb.la $libdir
| stderr:
| cp: cannot create 
/tmp/lt/build-hppa2.0w-hp-hpux11.11/tests/testsuite.dir/023/inst/lib/liba.sl.0.0:
 Permission denied
| stdout:
| libtool: install: cp .libs/liba.sl.0.0 
/tmp/lt/build-hppa2.0w-hp-hpux11.11/tests/testsuite.dir/023/inst/lib/liba.sl.0.0
| ../../libtool/tests/help.at:164: exit code was 1, expected 0
| 23. help.at:97: 23. debug tracing (help.at:97): FAILED (help.at:164)

This is because cp won't overwrite a file with mode 555; but install-sh
will.  We specifically use mode 555 on HP-UX because missing execute
permissions cause library loading to fail or be very slow, and the
installed system libraries al seem to not have w bits set either
(otherwise I would have suggested using 755 instead).

I should apologize for slightly messing up wrt. git log cleanliness in
that I introduced a merge on master because I didn't rebase on top of
Charles' last patch before merging master to the lto branch.  At least,
this way an eventual merge of the lto branch should be trivial.

Cheers,
Ralf

    tests: avoid spurious test failure due to library mode on HP-UX.
    
    * tests/help.at (debug tracing): Use $lt_INSTALL not cp for
    install mode, the latter will not overwrite an existing library
    with mode 555.

diff --git a/tests/help.at b/tests/help.at
index c4eaa87..0b60a0d 100644
--- a/tests/help.at
+++ b/tests/help.at
@@ -161,7 +161,7 @@ for trace in '' --debug; do
 
   # Hypothesis: --debug should be passed to relink mode if (and only if)
   # it was passed at link mode.
-  AT_CHECK([$orig_LIBTOOL --mode=install cp liba.la libb.la $libdir],
+  AT_CHECK([$orig_LIBTOOL --mode=install $lt_INSTALL liba.la libb.la $libdir],
           [], [stdout], [stderr])
   if grep ': relinking ' stdout stderr; then
     if test "X$trace" = X--debug; then



reply via email to

[Prev in Thread] Current Thread [Next in Thread]