[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Adjust naming of MSVC import libraries.
From: |
Gary V. Vaughan |
Subject: |
Re: [PATCH] Adjust naming of MSVC import libraries. |
Date: |
Tue, 7 Sep 2010 16:47:08 +0700 |
Hi Peter,
On 7 Sep 2010, at 16:25, Peter Rosin wrote:
> Den 2010-09-04 16:21 skrev Charles Wilson:
>> On 9/4/2010 4:52 AM, Peter Rosin wrote:
>>> And the testsuite runs have finished and results are the same. I still
>>> want to push this.
>>
>> I have no objections anymore, but I can't approve it.
>
> Here's a rebased and adjusted version now that 5/7 from the other thread
> has gone in and finalized the interface. The testsuite is still happy...
>
> Ok to push?
It seems to me that none of this patch affects non-win32 systems, so I
can't test it... otherwise I might have spoken up sooner.
> (or are you all on the 72 hour clock since the first post?
> I'm setting a new 72 hour clock now in case you're not)
No need for that I think. As long as the testsuite is still passing on
the systems that use this codepath, the original 72 hour clock is plenty
long enough time for any of us to exercise a veto, or ask for more time
to review.
> (BTW, what's up with the strange date generated by git in the next line?)
> --
> 1.7.1
Dunno, but git is up to 1.7.2.2. If you see it again after updating, please
forward a report to address@hidden
Cheers,
--
Gary V. Vaughan (address@hidden)
PGP.sig
Description: This is a digitally signed message part
- [PATCH] Adjust naming of MSVC import libraries., Peter Rosin, 2010/09/03
- [PATCH] Adjust naming of MSVC import libraries., Peter Rosin, 2010/09/03
- Re: [PATCH] Adjust naming of MSVC import libraries., Charles Wilson, 2010/09/03
- Re: [PATCH] Adjust naming of MSVC import libraries., Peter Rosin, 2010/09/03
- Re: [PATCH] Adjust naming of MSVC import libraries., Charles Wilson, 2010/09/03
- Re: [PATCH] Adjust naming of MSVC import libraries., Peter Rosin, 2010/09/04
- Re: [PATCH] Adjust naming of MSVC import libraries., Charles Wilson, 2010/09/04
- Re: [PATCH] Adjust naming of MSVC import libraries., Peter Rosin, 2010/09/04
- Re: [PATCH] Adjust naming of MSVC import libraries., Peter Rosin, 2010/09/07
- Re: [PATCH] Adjust naming of MSVC import libraries.,
Gary V. Vaughan <=
- Re: [PATCH] Adjust naming of MSVC import libraries., Peter Rosin, 2010/09/07
- Re: [PATCH] Adjust naming of MSVC import libraries., Ralf Wildenhues, 2010/09/07
- Re: [PATCH] Adjust naming of MSVC import libraries., Ralf Wildenhues, 2010/09/07
- Re: [PATCH] Adjust naming of MSVC import libraries., Peter Rosin, 2010/09/07
- Re: [PATCH] Adjust naming of MSVC import libraries., Ralf Wildenhues, 2010/09/08
- Re: [PATCH] Adjust naming of MSVC import libraries., Peter Rosin, 2010/09/08
- Re: [PATCH] Adjust naming of MSVC import libraries., Peter Rosin, 2010/09/08
- Re: [PATCH] Adjust naming of MSVC import libraries., Ralf Wildenhues, 2010/09/08
- Re: [PATCH] Adjust naming of MSVC import libraries., Peter Rosin, 2010/09/08