libtool-patches
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if "$foo" = .

From: Ralf Wildenhues
Subject: Re: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if "$foo" = ...'.
Date: Fri, 17 Sep 2010 19:06:51 +0200
User-agent: Mutt/1.5.20 (2010-08-04) 
* Peter Rosin wrote on Fri, Sep 17, 2010 at 12:37:07PM CEST:
> Subject: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if "$foo" = 
> ...'.

OK, but I find the log entry not really explaining the change.
How about this instead?

    tests: actually detect missing 'test' in 'if "$foo" = ...'.

    * tests/sh.test: Remove extra backslash in regex.

Thanks,
Ralf

> @@ -31,7 +31,7 @@
>  status=$EXIT_SUCCESS
>  
>  # Check for bad binary operators.
> -if $EGREP -n -e 'if[         ]+["'\'']?\\$[^         ]+[     
> ]+(=|-[lg][te]|-eq|-ne)' $scripts; then
> +if $EGREP -n -e 'if[         ]+["'\'']?\$[^  ]+[     
> ]+(=|-[lg][te]|-eq|-ne)' $scripts; then
>    echo "use \`if test \$something =' instead of \`if \$something ='"
>    status=$EXIT_FAILURE
>  fi
reply via email to
[Prev in Thread] Current Thread [Next in Thread]