Re: [PATCH] Fix order of PATH manipulation in cwrapper and shwrapper

[Charles Wilson]

On 9/17/2010 2:12 PM, Ralf Wildenhues wrote:
> * Charles Wilson wrote on Fri, Sep 17, 2010 at 06:23:28PM CEST:
>> * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src:main): Call
>> lt_update_exe_path before lt_update_lib_path, to ensure that the
>> temporary rpath values (which include the OBJDIRs of uninstalled
>> libtool libraries) precede installation and final -rpath directories.
>> (func_emit_wrapper): Prepend $dllsearchpath to PATH before prepending
>> $temp_rpath to $shlibpath_var; similar rationale as above.
>> Reported by Jon Turney <address@hidden>
> 
> This is OK.  I mention a nit below.

Pushed:

with this
# Fix the DLL searchpath if we need to.  Do this before prepending
# to shlibpath, because on Windows, both are PATH and uninstalled
# libraries must come first.

and this
/* Update the DLL searchpath.  EXE_PATH_VALUE ($dllsearchpath) must
   be prepended before (that is, appear after) LIB_PATH_VALUE ($temp_rpath)
   because on Windows, both *_VARNAMEs are PATH but uninstalled
   libraries must come first. */
which isn't really shorter than the previous version, but is probably a
little more clear, and models the new shwrapper commentary more closely.


I won't be able to do the test case before the release, especially not
today...

--
Chuck