Re: [PATCH 6/6] maint: use sed instead of maintaining 2 README files.

[Ralf Wildenhues]

Hello Gary,

* Gary V. Vaughan wrote on Sun, Sep 19, 2010 at 05:46:25AM CEST:
> On 18 Sep 2010, at 13:40, Ralf Wildenhues wrote:
> > * Gary V. Vaughan wrote on Sat, Sep 18, 2010 at 07:20:18AM CEST:
> >> +  sed -e '/^This is GNU Libtool,/,/^interface.$/c\
> >> +This is an alpha testing release of GNU Libtool, a generic library\
> >> +support script.  Libtool hides the complexity of using shared libraries\
> >> +behind a consistent, portable interface.' $file > $file.T \
> > 
> > this script will wrongly exit with status 0 if the stdout redirection
> > fails at this point.
> 
> Ah, true.  I was trying to keep the script simple, and overdid it a bit.  In
> light of that, and my having noticed that the script also didn't complain if
> sed was unable to match any text to edit, I've now improved the script thus:

Well, your improvements:

> >   # Make sure the paragraph we are matching has not been edited since
> >   # this script was written.
> >   matched=`sed -n -e '/^This is GNU Libtool,/,/^interface.$/p' $file \
> >       |wc -l |sed 's|^ *||'`
> >   test 3 = "$matched" \
> >       || func_fatal_error "$file format has changed, please fix \`$0'"

actually caused a regression: this code will cause 'make distcheck' to
fail, because at 'make dist' time the file will be rewritten before
being added to the tarball (if the version doesn't indicate a stable
release), then when distcheck tries to create yet another tarball, the
above check will catch:

| case 2.2.11a in \
|   *[a-z]) /bin/sh ../libltdl/config/edit-readme-alpha libtool-2.2.11a/README 
;; \
| esac
| edit-readme-alpha: libtool-2.2.11a/README format has changed, please fix 
`../libltdl/config/edit-readme-alpha'
| make[3]: *** [dist-hook] Error 1
| make[3]: *** Waiting for unfinished jobs....

Cheers,
Ralf