Re: [PATCH v2 07/11] build: make better use of automatic variables in `Makefile.am'.

[Ralf Wildenhues]

Hi Gary,

this isn't a review, I'm just adding a couple of hints that come to
mind at first glance.

* Gary V. Vaughan wrote on Thu, Sep 23, 2010 at 05:21:24PM CEST:
> Rules are getting shorter and more readable again now.  I'm assuming
> there are no portability problems with "$@" and "$^" in regular rules?

$@ is portable.  $^ is not portable.

These things are all documented.  Here's the Posix page for make:
<http://www.opengroup.org/onlinepubs/9699919799/utilities/make.html>
here are the Autoconf manual sections about portable make:
<http://www.gnu.org/software/autoconf/manual/html_node/Portable-Make.html>

> If there are, at least keeping this change in a separate patch makes
> it easy enough to omit or amend.

Thanks.  Please amend and resubmit, I will review then.

> Now that these rules are all executing from the build tree, there's
> no need to manually check all the paths match the current directory,
> or keep long hand-typed duplicate paths scattered around.  We can
> use $@ (and $^ in some places) knowing that they're still correct
> when we've stayed in the same directory they were calculated for.
> 
> Okay to push?
> 
> * Makefile.am (libtoolize, libtoolize.in, libltdl/Makefile.am)
> (libltdl/config/mkstamp, libltdl/config/ltmain.m4sh)
> (libltdl/m4/ltversion.m4, tests/testsuite,.tests/defs.in):
> Make better use of automatic variables.

Cheers,
Ralf