Re: [patch] allow --with-pic to accept package names

[Ralf Wildenhues]

Hi Ollie,

* Ollie Wild wrote on Fri, Oct 22, 2010 at 06:32:08PM CEST:
> >        Modify --with-pic to support per-package configurations.
> >        * libltdl/m4/libtool.m4:  Modify --with-pic to accept a list of
> >        package names.  Modelled off --enable-shared.
> 
> Peter, thanks for noticing the quoting bug.  Updated patch attached.

Thanks.  The patch still has the issues I described in
<http://article.gmane.org/gmane.comp.gnu.libtool.patches/10924>

Please indicate whether you are still working on any of those issues,
and which.

Thanks,
Ralf

> 2010-10-21  Ollie Wild  <address@hidden>
> 
>       Modify --with-pic to support per-package configurations.
>       * libltdl/m4/libtool.m4:  Modify --with-pic to accept a list of
>       package names.  Modelled off --enable-shared.
> 
> diff --git a/libltdl/m4/ltoptions.m4 b/libltdl/m4/ltoptions.m4
> index 17cfd51..160f7f2 100644
> --- a/libltdl/m4/ltoptions.m4
> +++ b/libltdl/m4/ltoptions.m4
> @@ -326,9 +326,24 @@ dnl AC_DEFUN([AM_DISABLE_FAST_INSTALL], [])
>  # MODE is either `yes' or `no'.  If omitted, it defaults to `both'.
>  m4_define([_LT_WITH_PIC],
>  [AC_ARG_WITH([pic],
> -    [AS_HELP_STRING([--with-pic],
> +    [AS_HELP_STRING([--with-pic@<:@=PKGS@:>@],
>       [try to use only PIC/non-PIC objects @<:@default=use both@:>@])],
> -    [pic_mode="$withval"],
> +    [p=${PACKAGE-default}
> +    case $withval in
> +    yes|no) pic_mode=$withval ;;
> +    *)
> +      pic_mode=default
> +      # Look at the argument we got.  We use all the common list separators.
> +      lt_save_ifs="$IFS"; IFS="${IFS}$PATH_SEPARATOR,"
> +      for pkg in $withval; do
> +     IFS="$lt_save_ifs"
> +     if test "X$pkg" = "X$p"; then
> +       pic_mode=yes
> +     fi
> +      done
> +      IFS="$lt_save_ifs"
> +      ;;
> +    esac],
>      [pic_mode=default])
>  
>  test -z "$pic_mode" && pic_mode=m4_default([$1], [default])