Re: Fix cwrapper test failure with --disable-static.

[Ralf Wildenhues]

Hi Charles,

* Charles Wilson wrote on Wed, Nov 10, 2010 at 09:46:54PM CET:
> On 11/10/2010 1:29 PM, Ralf Wildenhues wrote:
> >  
> > -AT_CHECK([$LIBTOOL --mode=compile --tag=CC $CC $CPPFLAGS $CFLAGS -c m.c],
> > -         [], [ignore], [ignore])
> > +AT_CHECK([$CC $CPPFLAGS $CFLAGS -c m.c], [], [ignore], [ignore])
> >  
> >  AT_CHECK([$LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o m1$EXEEXT m.$OBJEXT 
> > foo/liba.la],
> >           [], [ignore], [ignore])
> 
> Wouldn't a better fix be to change the link command to reference m.lo
> instead of m.$OBJEXT ?

That would be an alternative, but it would mean that we (needlessly) use
PIC code on systems where non-PIC is turned off by default (or
--disable-static was used).  automake-generated code also compiles
program sources without libtool, so the change was, to me, the canonical
one.

Is there a portability issue associated with it?

Thanks,
Ralf