[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: feed -no-undefined when linking libtool libraries
From: |
Peter Rosin |
Subject: |
Re: [PATCH] tests: feed -no-undefined when linking libtool libraries |
Date: |
Tue, 02 Oct 2012 19:32:34 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 |
[snipped loads of stuff]
On 2012-10-02 16:54, Gary V. Vaughan wrote:
> The new branch gary/reredo-test-operand-order (notice the double re) has
> everything broken down into digestible chunks. All the differences between
> that and master now look like improvements upon the original hand rolled
> version made by my recent scripted revisions, or else outright errors in
> the original corrected by the script. All the errors you flagged on the
> list are corrected, as well as several others.
That last bit makes me curious :-)
> Assuming my running 'make dist' doesn't have any regressions compared to
> master, and unless you have additional problems with Windows using the
> gary/reredo-test-operand-order branch, I plan to merge the differences
> back into master in a day or two.
You're saying that you are about to:
$ git checkout master
$ git merge --strategy=recursive -X theirs gary/reredo-test-operand-order \
-m 'bla bla bla'
right?
Is that better than committing the diff between reredo-... and master
as a revert-light? Why else would you have gone through all the trouble
of making all the smaller commits in the first place?
I just fired up a test suite run...
Cheers,
Peter [who is not as alert as he used to when reading diffs]