[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used.
From: |
Peter Rosin |
Subject: |
Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used. |
Date: |
Mon, 08 Oct 2012 18:01:21 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 |
On 2012-10-07 11:59, Roumen Petrov wrote:
> Peter Rosin wrote:
>> On 2012-09-19 23:02, Roumen Petrov wrote:
>>> What about to skip test only if DLL_EXPORT is in pic_flag ?
>> Since the patch has already been pushed and it is only a test
>> that may be skipped on some "other" platforms, I'm going to
>> wait for a bit until someone can confirm if this change has in
>> fact caused skips where the test used to pass. So, not
>> rushing this one...
>
> I can not understand why you expect someone to confirm.
> a) how many users use platform with "PIC default" ?
> b) how many users build with libtool instead that vendor (proprietary) build
> system ?
> c) how many users test libtool ?
> d) how many users report skipped tests if no one of the tests fail ?
e) how many users run unreleased libtools?
I wasn't *expecting* a *user* to confirm. I was *hoping* a
fellow *developer* could provide feedback.
>> Anyway, the change is simple if needed:
> So push it.
Right. Pushed, with fixed quoting.
Cheers,
Peter