Re: [PATCH] tests/testsuite.at: Don't use $as_echo

[Zack Weinberg]

On Mon, Mar 16, 2020 at 10:40 AM Eric Blake <address@hidden> wrote:
> On 3/13/20 4:27 PM, Zack Weinberg wrote:
> > tests/testsuite.at was using the undocumented internal shell variable
> > $as_echo to set its own variable $ECHO.  M4sh stopped setting this
> > variable in a patch committed to autoconf development trunk in January
> > of 2013, which was mostly harmless since there was a fallback setting
> > for $ECHO.  As of March 2020, however, merely mentioning $as_echo in
> > an m4sh input file will trigger a -Wobsolete warning.
> >
> > The fix is to promote the fallback setting to be the default setting
> > and not reference $as_echo anymore.  This is safe for the same reason
> > it was safe for autoconf to stop setting $as_echo -- 'printf %s\n' is a
> > reliable way to do echoing in all of the shells that are worth worrying
> > about anymore.
> > ---
> >   tests/testsuite.at | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
>
> ACK.

I don't have commit privileges on libtool, can you please apply this for me?

zw