libtool
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libtool-1.4


From: Gary V . Vaughan
Subject: Re: libtool-1.4
Date: Mon, 23 Apr 2001 01:56:31 +0100

On Saturday 21 April 2001 11:20 pm, Peter Eisentraut wrote:
>
> I'm not sure whether the compilation error is valid, but this system has
> a pretty pedantic C99 compiler.  Here's a patch:
>
> 2001-04-21  Peter Eisentraut  <address@hidden>
>
>       * libltdl/ltdl.c (trim): Don't inline.  Unixware 7.1.1's compiler
>       says you can't access static variables from inline functions.
>
> *** libltdl/ltdl.c.orig Sat Apr 21 15:35:56 2001
> --- libltdl/ltdl.c      Sat Apr 21 15:39:12 2001
> ***************
> *** 1943,1949 ****
>     return errors;
>   }
>
> ! static inline int
>   trim (dest, str)
>        char **dest;
>        const char *str;
> --- 1943,1949 ----
>     return errors;
>   }
>
> ! static int
>   trim (dest, str)
>        char **dest;
>        const char *str;

I must say that my spidey-sense tells me that `static inline' is a GNU 
extension... if I am right we should reduce all static inline's to static 
anyhow.

Okay to commit (with or without additional inline keyword removal)?

Cheers,
        Gary.
-- 
  ___              _   ___   __              _         mailto: address@hidden
 / __|__ _ _ ___ _| | / / | / /_ _ _  _ __ _| |_  __ _ ___       address@hidden
| (_ / _` | '_|// / |/ /| |/ / _` | || / _` | ' \/ _` | _ \
 \___\__,_|_|\_, /|___(_)___/\__,_|\_,_\__, |_||_\__,_|//_/
home page:  /___/                      /___/                  gpg public key:
http://www.oranda.demon.co.uk           http://www.oranda.demon.co.uk/key.asc



reply via email to

[Prev in Thread] Current Thread [Next in Thread]