libltdl & 64-bit lint

[Bob Friesenhahn]

Here is the output from Sun's 64-bit lint tool when run on libltdl
current as of September 29. You will notice that there are a number of
type down-conversions going on when the code is 64-bit.  In order to
be safe, these types should jive for both the ILP32 and LP64 data type
models.

I don't have ready access to a 64-bit development environment, so I am
passing this lint output on from someone else.

The "Solaris 64-bit Developer's Guide" available at
http://docs.sun.com/ provides an excellent overview of how to ensure
that source code will work under both data type models.

Bob

(390) warning: suspicious comparison of unsigned with 0: op "<="
(517) warning: constant in conditional context
(787) warning: constant in conditional context
(798) warning: constant in conditional context
(831) warning: constant in conditional context
(842) warning: constant in conditional context
(853) warning: constant in conditional context
(858) warning: constant in conditional context
(864) warning: constant in conditional context
(869) warning: constant in conditional context
(872) warning: constant in conditional context
(883) warning: constant in conditional context
(894) warning: constant in conditional context
(904) warning: constant in conditional context
(980) warning: constant in conditional context
(995) warning: constant in conditional context
(1012) warning: constant in conditional context
(1478) warning: constant in conditional context
(1486) warning: constant in conditional context
(1496) warning: constant in conditional context
(1504) warning: constant in conditional context
(1508) warning: constant in conditional context
(1529) warning: constant in conditional context
(1555) warning: constant in conditional context
(1567) warning: constant in conditional context
(1572) warning: constant in conditional context
(1602) warning: constant in conditional context
(1605) warning: constant in conditional context
(1638) warning: constant in conditional context
(1729) warning: constant in conditional context
(1756) warning: constant in conditional context
(1761) warning: constant in conditional context
(1766) warning: constant in conditional context
(1785) warning: constant in conditional context
(1790) warning: constant in conditional context
(1800) warning: constant in conditional context
(1802) warning: constant in conditional context
(1813) warning: constant in conditional context
(1818) warning: constant in conditional context
(1868) warning: constant in conditional context
(1874) warning: constant in conditional context
(1888) warning: constant in conditional context
(1889) warning: constant in conditional context
(1949) warning: constant in conditional context
(1955) warning: constant in conditional context
(1958) warning: constant in conditional context
(1994) warning: cast from 64-bit integer to 32-bit integer
(2009) warning: constant in conditional context
(2140) warning: constant in conditional context
(2143) warning: constant in conditional context
(2167) warning: assignment of 64-bit integer to 32-bit integer
(2173) warning: constant in conditional context
(2177) warning: constant in conditional context
(2184) warning: argument #3 is incompatible with prototype:
        prototype: pointer to unsigned long : "ltdl.c", line 2125
        argument : pointer to int
(2191) warning: assignment of 64-bit integer to 32-bit integer
(2195) warning: constant in conditional context
(2218) warning: constant in conditional context
(2219) warning: constant in conditional context
(2220) warning: constant in conditional context
(2222) warning: constant in conditional context
(2251) warning: constant in conditional context
(2502) warning: assignment of 64-bit integer to 32-bit integer
(2505) warning: constant in conditional context
(2532) warning: constant in conditional context
(2533) warning: constant in conditional context
(2534) warning: constant in conditional context
(2535) warning: constant in conditional context
(2557) warning: constant in conditional context
(2574) warning: constant in conditional context
(2611) warning: constant in conditional context
(2643) warning: comparing 32-bit integer with 64-bit integer
(2664) warning: constant in conditional context
(2668) warning: constant in conditional context
(2701) warning: constant in conditional context
(2718) warning: passing 64-bit integer arg, expecting 32-bit integer: fgets(arg 
2)
(2728) warning: passing 64-bit integer arg, expecting 32-bit integer: fgets(arg 
2)
(2794) warning: constant in conditional context
(2803) warning: constant in conditional context
(2813) warning: constant in conditional context
(2838) warning: constant in conditional context
(2881) warning: constant in conditional context
(2888) warning: constant in conditional context
(2893) warning: constant in conditional context
(2895) warning: constant in conditional context
(2898) warning: constant in conditional context
(2901) warning: constant in conditional context
(2904) warning: constant in conditional context
(2905) warning: constant in conditional context
(2906) warning: constant in conditional context
(2932) warning: constant in conditional context
(2960) warning: assignment of 64-bit integer to 32-bit integer
(2990) warning: constant in conditional context
(2998) warning: constant in conditional context
(3017) warning: constant in conditional context
(3024) warning: constant in conditional context
(3025) warning: constant in conditional context
(3044) warning: constant in conditional context
(3047) warning: constant in conditional context
(3141) warning: constant in conditional context
(3210) warning: constant in conditional context
(3235) warning: argument #4 is incompatible with prototype:
        prototype: pointer to void : "ltdl.c", line 2159
        argument : pointer to function(pointer to const char, pointer to void) 
returning int
(3241) warning: argument #4 is incompatible with prototype:
        prototype: pointer to void : "ltdl.c", line 2159
        argument : pointer to function(pointer to const char, pointer to void) 
returning int
(3245) warning: argument #4 is incompatible with prototype:
        prototype: pointer to void : "ltdl.c", line 2159
        argument : pointer to function(pointer to const char, pointer to void) 
returning int
(3252) warning: argument #4 is incompatible with prototype:
        prototype: pointer to void : "ltdl.c", line 2159
        argument : pointer to function(pointer to const char, pointer to void) 
returning int
(3259) warning: argument #4 is incompatible with prototype:
        prototype: pointer to void : "ltdl.c", line 2159
        argument : pointer to function(pointer to const char, pointer to void) 
returning int
(3274) warning: constant in conditional context
(3286) warning: constant in conditional context
(3314) warning: constant in conditional context
(3316) warning: constant in conditional context
(3317) warning: constant in conditional context
(3318) warning: constant in conditional context
(3325) warning: constant in conditional context
(3330) warning: constant in conditional context
(3348) warning: constant in conditional context
(3354) warning: constant in conditional context
(3358) warning: assignment of 64-bit integer to 32-bit integer
(3370) warning: constant in conditional context
(3380) warning: constant in conditional context
(3402) warning: constant in conditional context
(3406) warning: constant in conditional context
(3423) warning: constant in conditional context
(3434) warning: constant in conditional context
(3435) warning: constant in conditional context
(3503) warning: constant in conditional context
(3506) warning: constant in conditional context
(3507) warning: constant in conditional context
(3520) warning: constant in conditional context
(3523) warning: constant in conditional context
(3538) warning: constant in conditional context
(3542) warning: constant in conditional context
(3543) warning: constant in conditional context
(3546) warning: constant in conditional context
(3551) warning: constant in conditional context
(3557) warning: constant in conditional context
(3569) warning: constant in conditional context
(3570) warning: constant in conditional context
(3571) warning: constant in conditional context
(3578) warning: constant in conditional context
(3581) warning: constant in conditional context
(3591) warning: constant in conditional context
(3593) warning: constant in conditional context
(3606) warning: constant in conditional context
(3623) warning: constant in conditional context
(3641) warning: constant in conditional context
(3663) warning: constant in conditional context
(3678) warning: constant in conditional context
(3689) warning: constant in conditional context
(3691) warning: constant in conditional context
(3708) warning: constant in conditional context
(3746) warning: constant in conditional context
(3760) warning: constant in conditional context
(3775) warning: constant in conditional context
(3799) warning: constant in conditional context
(3817) warning: constant in conditional context
(3850) warning: constant in conditional context
(3861) warning: constant in conditional context
(3876) warning: constant in conditional context
(3880) warning: constant in conditional context
(3887) warning: constant in conditional context
(3919) warning: constant in conditional context
(3922) warning: constant in conditional context
(3933) warning: constant in conditional context
(3935) warning: constant in conditional context
(3948) warning: constant in conditional context
(3950) warning: constant in conditional context
(3954) warning: constant in conditional context
(3968) warning: constant in conditional context
(3970) warning: constant in conditional context
(3974) warning: constant in conditional context
(3986) warning: constant in conditional context
(3994) warning: constant in conditional context

argument unused in function
    (972) loader_data in sys_dl_open
    (987) loader_data in sys_dl_close
    (1003) loader_data in sys_dl_sym
    (1473) loader_data in presym_init
    (1514) loader_data in presym_exit
    (1560) loader_data in presym_open
    (1610) loader_data in presym_close
    (1620) loader_data in presym_sym
    (2273) ignored in find_handle_callback
    (2312) deplibs in load_deplibs

name defined but never used
    lt_dlrealloc        ltdl.c(166)
    lt_dlmutex_register         ltdl.c(777)
    lt_dladderror       ltdl.c(822)
    lt_dlseterror       ltdl.c(848)
    lt_dlinit           ltdl.c(1725)
    lt_dlpreload_default        ltdl.c(1797)
    lt_dlexit           ltdl.c(1807)
    lt_dlopenext        ltdl.c(2944)
    lt_dlforeachfile    ltdl.c(3223)
    lt_dlsym            ltdl.c(3336)
    lt_dlerror          ltdl.c(3430)
    lt_dladdsearchdir   ltdl.c(3513)
    lt_dlinsertsearchdir        ltdl.c(3530)
    lt_dlsetsearchpath  ltdl.c(3564)
    lt_dlgetsearchpath  ltdl.c(3587)
    lt_dlmakeresident   ltdl.c(3599)
    lt_dlisresident     ltdl.c(3618)
    lt_dlgetinfo        ltdl.c(3636)
    lt_dlhandle_next    ltdl.c(3649)
    lt_dlforeach        ltdl.c(3656)
    lt_dlcaller_register        ltdl.c(3684)
    lt_dlcaller_set_data        ltdl.c(3697)
    lt_dlcaller_get_data        ltdl.c(3752)
    lt_dlloader_remove  ltdl.c(3867)
    lt_dlloader_name    ltdl.c(3941)
    lt_dlloader_data    ltdl.c(3961)

name declared but never used or defined
    mallopt             malloc.h(49)
    lt_dlmutex_lock     ltdl.h(183)
    lt_dlmutex_unlock   ltdl.h(184)
    lt_dlmutex_seterror         ltdl.h(185)
    lt_dlmutex_geterror         ltdl.h(186)
    lt_module_open      ltdl.h(270)
    lt_module_close     ltdl.h(272)
    lt_find_sym         ltdl.h(274)
    lt_dlloader_exit    ltdl.h(277)
    foreach_callback_func       ltdl.c(1655)

function returns value which is always ignored
    presym_free_symlists    free_vars           closedir            fclose
    sprintf             memcpy              memset              memmove
    strcat              strcpy              strncat             strncpy


function returns value which is sometimes ignored
    tryall_dlopen       foreach_dirinpath    unload_deplibs  

declared global, could be static
    lt_dlmalloc         ltdl.c(164)
    lt_dlfree           ltdl.c(168)
    lt_dlpreload        ltdl.c(1772)
    lt_dlopen           ltdl.c(2912)
    lt_dlclose          ltdl.c(3268)
    lt_dlloader_add     ltdl.c(3786)
    lt_dlloader_next    ltdl.c(3928)
    lt_dlloader_find    ltdl.c(3981)