libtool
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: Fix mips*-*-linux*


From: Robert Boehne
Subject: Re: PATCH: Fix mips*-*-linux*
Date: Tue, 23 Oct 2001 11:24:42 -0500

Hello,

Here is the patch reworked for HEAD.  If noone objects
I'll commit it.

ChangeLog Entry:

2001-10-23  H.J. Lu <address@hidden>

        * ltmain.sh: Allow link against an archive when building a
        shared library.

        * libtool.m4 (lt_cv_deplibs_check_method): Always use
        file_magic for Linux ELF.


"H . J . Lu" wrote:
> 
> On Mon, Oct 22, 2001 at 03:47:17PM -0500, Robert Boehne wrote:
> > Why don't you send us the correct fix?
> >
> > "H . J . Lu" wrote:
> > >
> > > It is very stupid for libtool.m4 to break other Linux platforms just
> > > because Linux/ARM is different. Here is a patch for Linux/mips.
> > > However, the correct fix should be
> > >
> > >         case $host_cpu in
> > >         arm*)
> > >          # Handle ARM differently.
> > >          ....
> > >          ;;
> > >         *)
> > >           lt_cv_deplibs_check_method=pass_all ;;
> > >         esac
> > >
> 
> Here is the right fix:
> 
> http://mail.gnu.org/pipermail/libtool/2001-October/005690.html
> 
> It is against libtool used in binutils. I don't have time to figure
> out where it came frome.
> 
> H.J.

-- 
Robert Boehne             Software Engineer
Ricardo Software   Chicago Technical Center
TEL: (630)789-0003 x. 238
FAX: (630)789-0127
email:  address@hidden
ChangeLog Entry:

2001-10-22  H.J. Lu <address@hidden>

        * ltmain.sh: Allow link against an archive when building a
        shared library.

        * libtool.m4 (lt_cv_deplibs_check_method): Always use
        file_magic for Linux ELF.


Index: libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/libtool.m4,v
retrieving revision 1.238
diff -u -r1.238 libtool.m4
--- libtool.m4  2001/09/30 10:20:29     1.238
+++ libtool.m4  2001/10/23 16:20:36
@@ -1944,6 +1944,7 @@
     # glibc up to 2.1.1 does not perform some relocations on ARM
     lt_cv_deplibs_check_method='file_magic ELF [[0-9]][[0-9]]*-bit [[LM]]SB 
(shared object|dynamic lib )' ;;
   esac
+  lt_cv_deplibs_check_method='file_magic ELF [[0-9]][[0-9]]*-bit [[LM]]SB 
(shared object|dynamic lib )'
   lt_cv_file_magic_test_file=`echo /lib/libc.so* /lib/libc-*.so`
   ;;
 
Index: ltmain.in
===================================================================
RCS file: /cvsroot/libtool/libtool/ltmain.in,v
retrieving revision 1.278
diff -u -r1.278 ltmain.in
--- ltmain.in   2001/09/22 13:39:21     1.278
+++ ltmain.in   2001/10/23 16:20:36
@@ -2973,6 +2973,13 @@
                        *) potlib=`$echo "X$potlib" | $Xsed -e 
's,[^/]*$,,'`"$potliblink";;
                        esac
                      done
+                     # It is ok to link against an archive when
+                     # building a shared library.
+                     if $AR -t $potlib > /dev/null 2>&1; then
+                       newdeplibs="$newdeplibs $a_deplib"
+                       a_deplib=""
+                       break 2
+                     fi
                      if eval $file_magic_cmd \"\$potlib\" 2>/dev/null \
                         | sed 10q \
                         | egrep "$file_magic_regex" > /dev/null; then

reply via email to

[Prev in Thread] Current Thread [Next in Thread]