[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
libtool/MinGW DLLs patch - tidied up section 2
From: |
Max Bowsher |
Subject: |
libtool/MinGW DLLs patch - tidied up section 2 |
Date: |
Wed, 18 Sep 2002 09:17:19 +0100 |
I am tidying and explaining my patch bit by bit. Here is the second chunk.
A libtool expert needs to check Hunk 2. See my comments below
Once section 1 and 2 have been pronounced OK, they can be commited, as they are
just groundwork for the main chunk of the patch, and can stand alone.
Max.
------ from here is the text of the attatchment, for ease of viewing /
discussion ------
Explanation: These are the remaining changes which do not require policy
discussion on the MinGW mailing list. That's not to say they don't
need code discussion.
Hunk 1: Move a line from a Cygwin-only section to its parent all-Win32 section.
This is accurate because there is no runpath on Win32. Unless there is a
'there_is_no_runpath' flag for libtool that I have missed? :-)
Hunk 2: Without this, if CC is a program name with arguments, those arguments
were being lost in the plain C case only. I noted that a line of this
form was missing in the plain C case as compared to other language tags.
However, I just guessed that it might be the problem, and it worked! So,
could someone more experienced with libtool internals check this?
--- libtool.m4.cvs+01 2002-09-18 08:45:58.000000000 +0100
+++ libtool.m4.cvs+01+02 2002-09-18 08:52:39.000000000 +0100
@@ -1124,6 +1124,7 @@
version_type=windows
need_version=no
need_lib_prefix=no
+ shlibpath_overrides_runpath=yes
case $GCC,$host_os in
yes,cygwin*)
library_names_spec='$libname.dll.a'
@@ -1137,7 +1138,6 @@
postuninstall_cmds='dldll=`bash 2>&1 -c '\''. $file; echo \$dlname'\''`~
dlpath=$dir/\$dldll~
$rm \$dlpath'
- shlibpath_overrides_runpath=yes
;;
yes,mingw*)
library_names_spec='${libname}`echo ${release} | sed -e
's/[[.]]/-/g'`${versuffix}.dll'
@@ -2298,6 +2298,8 @@
_LT_AC_SYS_COMPILER
+_LT_AC_TAGVAR(compiler, $1)=$CC
+
#
# Check for any special shared library compilation flags.
#
END_OF_PATCH
max-libtool.m4-02-misc.patch
Description: Text document
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- libtool/MinGW DLLs patch - tidied up section 2,
Max Bowsher <=