Re: tag inference broken?

[Scott James Remnant]

On Sun, 2003-12-07 at 23:18, Peter O'Gorman wrote:

> Scott James Remnant wrote:
> 
> | On Sat, 2003-12-06 at 15:14, Peter O'Gorman wrote:
> |>Looks like it is simply infering too early in link mode.
> |>
> |
> | Yeah, my last patch moved the code to before the rest of the argument
> | parsing to make -shared, -static and -all-static work with a tagged
> | configuration.
> |
> 
> Actually, I "fixed" it much more simply by changing the
> case "$base_compile "
> to
> case "$base_compile $@" in both places in link mode.
> 
That'd work too, as far as I can see the loop just sticks every $arg
into $base_compile anyway.

Hell, we could probably get away with the following patch and that'd
probably result in exactly the same thing, there's nothing that breaks
out of that loop.

Scott
-- 
Have you ever, ever felt like this?
Had strange things happen?  Are you going round the twist?

--- ltmain.in.orig      2003-12-17 23:21:55.000000000 +0000
+++ ltmain.in   2003-12-17 23:22:30.000000000 +0000
@@ -856,7 +856,7 @@
       ;;
     esac
     libtool_args="$nonopt"
-    base_compile="$nonopt"
+    base_compile="$nonopt $@"
     compile_command="$nonopt"
     finalize_command="$nonopt"
 
@@ -906,7 +906,7 @@
     # Only attempt this if the compiler in the base link
     # command doesn't match the default compiler.
     if test -n "$available_tags" && test -z "$tagname"; then
-      case "$base_compile " in
+      case $base_compile in
       # Blanks in the command may have been stripped by the calling shell,
       # but not from the CC environment variable when configure was run.
       "$CC "* | " $CC "* | "`$echo $CC` "* | " `$echo $CC` "*) ;;
@@ -917,7 +917,7 @@
          if grep "^# ### BEGIN LIBTOOL TAG CONFIG: $z$" < "$0" > /dev/null; 
then
            # Evaluate the configuration.
            eval "`${SED} -n -e '/^# ### BEGIN LIBTOOL TAG CONFIG: '$z'$/,/^# 
### END LIBTOOL TAG CONFIG: '$z'$/p' < $0`"
-           case "$base_compile " in
+           case $base_compile in
            "$CC "* | " $CC "* | "`$echo $CC` "* | " `$echo $CC` "*)
              # The compiler in $compile_command matches
              # the one in the tagged configuration.
@@ -985,7 +985,6 @@
     # Go through the arguments, transforming them on the way.
     while test "$#" -gt 0; do
       arg="$1"
-      base_compile="$base_compile $arg"
       shift
       case $arg in
       *[\[\~\#\^\&\*\(\)\{\}\|\;\<\>\?\'\ \    ]*|*]*|"")

signature.asc
Description: This is a digitally signed message part