Re: cvs build prob

[Gary V. Vaughan]

Alexandre Duret-Lutz wrote:
> On Tue, Jul 27, 2004 at 05:15:17PM +0100, Patrick Welche wrote:
> 
>>Reminder of the miscreant line:
>>
>>  output_verbose_link_cmd="`$echo \"X$output_verbose_link_cmd\" | $Xsed -e 
>> \"$no_glob_subst\"`"
>>
> 
> 
> Why not replacing it with
> 
> output_verbose_link_cmd=`$echo "X$output_verbose_link_cmd" | $Xsed 
> "$no_glob_subst"`
> 
> ?
> 
> The right-hand side of `=' is never IFS-splitted, so the outermost
> double quotes are superfluous.

Indeed!  Patrick, can you confirm that this fixes it for you?  You'll probably
encounter another problem in the same area that I am working on, but you
should see a different error message at least :-(

We probably need to audit the whole of libtool for nested quotes, and add
a test case to sh.test to stop us introducing more.  Bonus marks for a patch :*)

Cheers,
        Gary.
-- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature