[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cvs build prob

From: Gary V. Vaughan
Subject: Re: cvs build prob
Date: Tue, 27 Jul 2004 17:32:05 +0100
User-agent: Mozilla Thunderbird 0.7 (X11/20040615)

Alexandre Duret-Lutz wrote:
> On Tue, Jul 27, 2004 at 05:15:17PM +0100, Patrick Welche wrote:
>>Reminder of the miscreant line:
>>  output_verbose_link_cmd="`$echo \"X$output_verbose_link_cmd\" | $Xsed -e 
>> \"$no_glob_subst\"`"
> Why not replacing it with
> output_verbose_link_cmd=`$echo "X$output_verbose_link_cmd" | $Xsed 
> "$no_glob_subst"`
> ?
> The right-hand side of `=' is never IFS-splitted, so the outermost
> double quotes are superfluous.

Indeed!  Patrick, can you confirm that this fixes it for you?  You'll probably
encounter another problem in the same area that I am working on, but you
should see a different error message at least :-(

We probably need to audit the whole of libtool for nested quotes, and add
a test case to sh.test to stop us introducing more.  Bonus marks for a patch :*)

Gary V. Vaughan      ())_.  address@hidden,}
Research Scientist   ( '/
GNU Hacker           / )=
Technical Author   `(_~)_

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]