FYI: libtool.m4 correction

[Ralf Wildenhues]

Hi Guido,

* Guido Draheim wrote on Fri, Jan 14, 2005 at 04:54:27AM CET:
>  # Add /usr/xpg4/bin/sed as it is typically found on Solaris
>  # along with /bin/sed that truncates output.
>  for lt_ac_sed in $lt_ac_sed_list /usr/xpg4/bin/sed; do
> -  test ! -f $lt_ac_sed && break
> +  test ! -f $lt_ac_sed && continue
>    cat /dev/null > conftest.in
>    lt_ac_count=0
> 
> On one of my build hosts the loop will break before
> any good sed is being found even that there is one
> good sed later in the path. The current cvs version
> will break if any directory item in $PATH does not
> contain an sed candidate.

Well, only if as_executable_p is nonfunctional in the loop before the
one you posted, and your Autoconf is not new enough to have AC_PROG_SED.
Of course, the former is our failure to use it correctly, and the latter
just hides the bug for many users.

> > rpm -q libtool
> libtool-1.5.8-3
> 
> savannah cvsweb shows the same line. Longstanding?

Sure, I guess most Libtool developers use quite modern Autoconf, so this
macro is not used by them at all.

Thanks for your report.  I've checked in the following patch against all
three branches.

Regards,
Ralf

2005-01-14  Guido Draheim  <address@hidden>  (tiny change)

        * m4/libtool.m4 (AC_PROG_SED): Don't break test loop early.

Index: m4/libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/m4/libtool.m4,v
retrieving revision 1.153
diff -u -r1.153 libtool.m4
--- m4/libtool.m4       12 Jan 2005 12:57:32 -0000      1.153
+++ m4/libtool.m4       14 Jan 2005 09:19:30 -0000
@@ -5970,7 +5970,7 @@
 # Add /usr/xpg4/bin/sed as it is typically found on Solaris
 # along with /bin/sed that truncates output.
 for lt_ac_sed in $lt_ac_sed_list /usr/xpg4/bin/sed; do
-  test ! -f $lt_ac_sed && break
+  test ! -f $lt_ac_sed && continue
   cat /dev/null > conftest.in
   lt_ac_count=0
   $ECHO $ECHO_N "0123456789$ECHO_C" >conftest.in