FYI: libtool 2.1a failed mdemo-make.test on Solaris

[Ralf Wildenhues]

* Ralf Wildenhues wrote on Thu, Jun 23, 2005 at 12:25:01PM CEST:
> * Sven Verdoolaege wrote on Thu, Jun 23, 2005 at 09:11:36AM CEST:
> > On Thu, Jun 23, 2005 at 08:31:48AM +0200, Ralf Wildenhues wrote:
> > 
> > > > It's this version that fails on solaris.
> > > 
> > > Let's see: ls libltdl/argz.h created by running `make' in $top_builddir?
> > 
> > Yes.  I ran "make check" without a "make" first.
> > This seems to work on Linux...
> 
> Yes, but that works only because GNU/Linux has argz.h.
> 
> > Running make first makes tests/mdemo-make.test pass on Solaris.
> 
> Ah, ok.  Thanks for this report.  It's a bit tricky to reproduce: You
> need a system which has no argz.h, then configure, then `make check'
> without prior make.  If you had ever run `make' before in this build
> tree, even after `make clean' the dependency information is stored in
> libltdl/.deps/*.Plo, and thus hides this bug.
> 
> Now the gnulib snippet in libltdl/Makefile.am leaves us with the
> possibility of using the lib_OBJECTS variable to fix this(?).

OK, nobody from the other two lists responded, so I am doing a different
fix which does not depend on undocumented features (and seems cleaner as
well).

I have applied this patch to HEAD and branch-2-0 (does not apply to
branch-1-5).

Cheers,
Ralf

        * libltdl/Makefile.am (libltdl_la_DEPENDENCIES): Depend on
        $(BUILT_SOURCES) as well, so that argz.h gets created through
        `make libltdlc.la'.
        Reported by Sven Verdoolaege <address@hidden>.

Index: libltdl/Makefile.am
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/Makefile.am,v
retrieving revision 1.80
diff -u -r1.80 Makefile.am
--- libltdl/Makefile.am 22 Apr 2005 10:10:30 -0000      1.80
+++ libltdl/Makefile.am 8 Jul 2005 16:14:47 -0000
@@ -63,7 +63,7 @@
 libltdl_la_CPPFLAGS    = -DLTDLOPEN=libltdl $(AM_CPPFLAGS)
 libltdl_la_LDFLAGS     = $(AM_LDFLAGS) $(VERSION_INFO) $(LT_DLPREOPEN)
 libltdl_la_LIBADD      = $(LTLIBOBJS)
-libltdl_la_DEPENDENCIES        = $(LT_DLLOADERS) $(LTLIBOBJS)
+libltdl_la_DEPENDENCIES        = $(LT_DLLOADERS) $(LTLIBOBJS) $(BUILT_SOURCES)
 
 libltdlc_la_SOURCES    = $(libltdl_la_SOURCES)
 libltdlc_la_CPPFLAGS   = -DLTDLOPEN=libltdlc $(AM_CPPFLAGS)