RE: [png-mng-implement] -version-number and BeOS

[John Bowler]

From: Christian Biesinger
>libtool: link: CURRENT `' must be a nonnegative integer
>libtool: link: `0:9:0' is not valid version information
>make[1]: *** [libpng12.la] Error 1
>
>(Note that libpng 1.2.8 is OK (in this regard), as it uses -version-info 
>rather than -version-number)
>
>The cause of this problem seems to be this:
>For BeOS, version_type=none. But, the code in ltmain.sh around line 3236 
>does not handle a value of none. Only for the specific list of cases 
>does it assign a value to current, age and revision.

Yes, we found a similar problem with irix and I patched ltmain.sh
to fix this (ltmain.sh is shipped with the package, so patching it
works):

$ diff libpng-1.2.9beta7/ltmain.sh libpng-1.2.9beta11
3248c3248
<           current=`expr $number_major + $number_minor - 1`
---
>           current=`expr $number_major + $number_minor`
3323c3323
<         major=`expr $current - $age + 1`
---
>         major=`expr $current - $age`

For BeOS try adding 'none' to the end of the test for darwin|linux|osf|windows
on line 3237 of ltmain.sh.  We can ship libpng with that because it won't
break anything which isn't already broken.  I.e:

--- ltmain.sh   Wed Mar  8 10:26:46 2006
+++ ltmain.sh.new       Fri Mar 31 11:14:49 2006
@@ -3234,7 +3234,7 @@ EOF
          # which has an extra 1 added just for fun
          #
          case $version_type in
-         darwin|linux|osf|windows)
+         darwin|linux|osf|windows|none)
            current=`expr $number_major + $number_minor`
            age="$number_minor"
            revision="$number_revision"

John Bowler <address@hidden>