libtool
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

libtool filters gcc coverage flags breaking linking step


From: Mike Frysinger
Subject: libtool filters gcc coverage flags breaking linking step
Date: Sat, 30 Dec 2006 10:40:12 -0500
User-agent: KMail/1.9.5

the attached tarball illustrates a small package that breaks because libtool 
does not allow -fprofile-arcs or -fprofile-generate ... looking through 
latest cvs, i see that --coverage was added, but not these other flags

the builtin gcc spec allows for any of these flags to be used:
    %{fprofile-arcs|fprofile-generate|coverage:-lgcov}\

also, it would seem that -p is filtered but -pg is let through ...

the attached patch against CVS head should do the trick i think
-mike

Attachment: pgpSVdcmdnhIW.pgp
Description: PGP signature

Attachment: gcov-libtool.tar.bz2
Description: application/tbz

2006-12-30  Mike Frysinger  <address@hidden>

        * libltdl/config/ltmain.m4sh (func_mode_link): Pass through
        `-p', `-fprofile-arcs', and `-fprofile-generate' for GCC.

Index: libltdl/config/ltmain.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/config/ltmain.m4sh,v
retrieving revision 1.56
diff -u -p -r1.56 ltmain.m4sh
--- libltdl/config/ltmain.m4sh  22 Oct 2006 14:10:33 -0000      1.56
+++ libltdl/config/ltmain.m4sh  30 Dec 2006 15:37:08 -0000
@@ -2902,10 +2902,11 @@ func_mode_link ()
       # -m*, -t[45]*, -txscale* pass through architecture-specific
       # compiler args for GCC
       # -F/path gives path to uninstalled frameworks, gcc on darwin
-      # -pg, --coverage pass through profiling flag for GCC
+      # -p, -pg, --coverage, -fprofile-arcs, -fprofile-generate pass
+      # through profiling flag for GCC
       # @file GCC response files
       
-64|-mips[[0-9]]|-r[[0-9]][[0-9]]*|-xarch=*|-xtarget=*|+DA*|+DD*|-q*|-m*| \
-      -t[[45]]*|-txscale*|-pg|--coverage|-F*|@*)
+      
-t[[45]]*|-txscale*|-p|-pg|--coverage|-fprofile-arcs|-fprofile-generate|-F*|@*)
         func_quote_for_eval "$arg"
        arg="$func_quote_for_eval_result"
         func_append compile_command " $arg"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]